tests: restore previous environment variables used in ConfigTest

Author: Javier Marín

tests/ConfigTest.php

@@ -13,9 +13,38 @@
 use RobiNN\Pca\Config;
 
 final class ConfigTest extends TestCase {
+    /**
+     * @var array<string, string|false>
+     */
+    private array $envBackup = [];
+
     protected function tearDown(): void {
-        parent::tearDown();
+        // Restore environment variables to their original state
+        foreach ($this->envBackup as $name => $value) {
+            if ($value === false) {
+                putenv($name);
+            } else {
+                putenv("$name=$value");
+            }
+        }
+
+        // Reset the backup array for the next test
+        $this->envBackup = [];
+
         Config::reset();
+        parent::tearDown();
+    }
+
+    /**
+     * Helper to set env var and back up the original value
+     */
+    private function setEnv(string $name, string $value): void {
+        // Only backup the first time we touch this variable in a test
+        if (!array_key_exists($name, $this->envBackup)) {
+            $this->envBackup[$name] = getenv($name);
+        }
+
+        putenv("{$name}={$value}");
     }
 
     public function testGetter(): void {
@@ -29,18 +58,19 @@ public function testGetter(): void {
      * @throws JsonException
      */
     public function testEnvGetter(): void {
-        putenv('PCA_TESTENV-ARRAY='.json_encode(['item1' => 'value1', 'item2' => 'value2'], JSON_THROW_ON_ERROR));
+        $this->setEnv('PCA_TESTENV-ARRAY', json_encode(['item1' => 'value1', 'item2' => 'value2'], JSON_THROW_ON_ERROR));
         $this->assertSame('value1', Config::get('testenv-array', [])['item1']);
     }
 
     public function testEnvInt(): void {
-        putenv('PCA_TESTENV-INT=10');
+        $this->setEnv('PCA_TESTENV-INT', '10');
 
         $this->assertSame(10, Config::get('testenv-int', 2));
     }
 
     public function testEnvArray(): void {
-        putenv('PCA_TESTENV-JSON={"local_cert":"path/to/redis.crt","local_pk":"path/to/redis.key","cafile":"path/to/ca.crt","verify_peer_name":false}');
+        $this->setEnv('PCA_TESTENV-JSON', '{"local_cert":"path/to/redis.crt","local_pk":"path/to/redis.key","cafile":"path/to/ca.crt","verify_peer_name":false}');
+
         $this->assertEqualsCanonicalizing([
             'local_cert'       => 'path/to/redis.crt',
             'local_pk'         => 'path/to/redis.key',
@@ -55,16 +85,16 @@ public function testEnvOverride(): void {
 
         Config::reset();
 
-        putenv('PCA_TIMEFORMAT=d. m. Y');
+        $this->setEnv('PCA_TIMEFORMAT', 'd. m. Y');
 
         $this->assertSame('d. m. Y', Config::get('timeformat', ''));
     }
 
     public function testEnvNested(): void {
-        putenv('PCA_REDIS_0_HOST=127.0.0.1');
-        putenv('PCA_REDIS_0_PORT=6379');
-        putenv('PCA_REDIS_2_HOST=localhost');
-        putenv('PCA_REDIS_2_PORT=6380');
+        $this->setEnv('PCA_REDIS_0_HOST', '127.0.0.1');
+        $this->setEnv('PCA_REDIS_0_PORT', '6379');
+        $this->setEnv('PCA_REDIS_2_HOST', 'localhost');
+        $this->setEnv('PCA_REDIS_2_PORT', '6380');
 
         $redis_config = Config::get('redis', []);
 
@@ -76,15 +106,15 @@ public function testEnvNested(): void {
     }
 
     public function testEnvCollisionWithScalar(): void {
-        putenv('PCA_TIMEFORMAT=d. m. Y H:i:s');
-        putenv('PCA_TIMEFORMAT_EXTRA=test');
+        $this->setEnv('PCA_TIMEFORMAT', 'd. m. Y H:i:s');
+        $this->setEnv('PCA_TIMEFORMAT_EXTRA', 'test');
 
         $this->assertSame('d. m. Y H:i:s', Config::get('timeformat', ''));
         $this->assertSame('test', Config::get('timeformat_extra'));
     }
 
     public function testEnvSnakeCase(): void {
-        putenv('PCA_SOME_SNAKE_CASE_KEY=value');
+        $this->setEnv('PCA_SOME_SNAKE_CASE_KEY', 'value');
 
         $this->assertSame('value', Config::get('some_snake_case_key'));
     }