Would it be possible to add a function to emit to the whole room, including the sender of the original event?

[Miodec]

Looking at the docs, you can only emit to the sender, or broadcast to the room excluding the sender. Would it be possible to add something like withRooms(id).emit()?

I realise i can probably do

client.emit()
withRooms(id).broadcast()

but having to remember to call both could be prone to errors.

What do you think?

[Miodec]

Actually, after testing, it seems like using withRooms.broadcast in the action handler DOES send an event to the sender of that event, but the docs state that it should be sent to everyone EXCEPT the sender. Is this an issue with the docs, code, me?

export default factory.build({
  event: "room_toggle_visibility",
  input: z.tuple([]),
  handler: async ({ client, withRooms }) => {
    const user = UserController.get(client.id);
    const room = RoomController.get(user.room?.id ?? "");

    if (!room) {
      UserController.sendNotification(user.id, "You are not in a room", 0);
      return;
    }
    if (!user.isLeader) {
      UserController.sendNotification(user.id, "You are not the leader", 0);
      return;
    }
    if (room.type !== "custom") {
      UserController.sendNotification(
        user.id,
        "You can't change the visibility of this room",
        0,
      );
      return;
    }

    // RoomController.toggleVisibility(room.id);

    await withRooms(room.id).broadcast("room_chat_message", {
      message: "this is a test message",
      isSystem: true,
    });
  },
});

[Miodec]

Shouldn't the subject here be socket not ns?

zod-sockets/src/attach.ts

Line 95 in 3589cb3

withRooms: makeRoomService({ subject: ns, metadata, ...emitCfg }),

[Miodec]

AI thinks this is indeed a source code issue (all though i cant verify that so ill just pass my findings on to you and let you decide how to move forward).

Claude suggested to add a sender param:

      const ctx: ClientContext<NSEmissions, NSMeta> = {
        ...nsCtx,
        client,
        withRooms: makeRoomService({
          subject: ns,
          sender: socket,
          metadata,
          ...emitCfg,
        }),
      };

and then when making the room service, modifying the subject depending on the sender:

export const makeRoomService =
  <E extends EmissionMap, D extends z.ZodObject>({
    subject,
    sender,
    ...rest
  }: {
    subject: Socket | Server | Namespace;
    sender?: Socket;
    metadata: D;
  } & EmitterConfig<E>): RoomService<E, D> =>
  (rooms) => ({
    getClients: async () =>
      makeRemoteClients({
        sockets: await subject.in(rooms).fetchSockets(),
        ...rest,
      }),
    emit: makeEmitter({
      ...rest,
      subject: subject.to(rooms),
    }),
    broadcast: makeEmitter({
      ...rest,
      subject: sender ? sender.to(rooms) : subject.to(rooms),
    }),
  });

The one issue is that this could potentially be a breaking change, so it might require a new major version?