Skip to content

Commit 3a33ecc

Browse files
Build(deps-dev): Bump the eslint-and-eslint-plugins group with 2 updates (#1136)
* Build(deps-dev): Bump the eslint-and-eslint-plugins group with 2 updates Bumps the eslint-and-eslint-plugins group with 2 updates: [globals](https://github.com/sindresorhus/globals) and [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint). Updates `globals` from 16.5.0 to 17.0.0 - [Release notes](https://github.com/sindresorhus/globals/releases) - [Commits](sindresorhus/globals@v16.5.0...v17.0.0) Updates `typescript-eslint` from 8.50.0 to 8.51.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.51.0/packages/typescript-eslint) --- updated-dependencies: - dependency-name: globals dependency-version: 17.0.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: eslint-and-eslint-plugins - dependency-name: typescript-eslint dependency-version: 8.51.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: eslint-and-eslint-plugins ... Signed-off-by: dependabot[bot] <support@github.com> * (roslib) satisfy updated eslint rules --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Matthijs van der Burgh <matthijs.van.der.burgh@vbti.nl>
1 parent 08a2d3a commit 3a33ecc

File tree

3 files changed

+76
-82
lines changed

3 files changed

+76
-82
lines changed

package-lock.json

Lines changed: 72 additions & 72 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/roslib/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,13 @@
2828
"eslint-plugin-import": "^2.32.0",
2929
"eslint-plugin-jsdoc": "^61.5.0",
3030
"eslint-plugin-prettier": "^5.5.4",
31-
"globals": "^16.0.0",
31+
"globals": "^17.0.0",
3232
"jiti": "^2.6.1",
3333
"jsdom": "^27.4.0",
3434
"jspm": "^4.2.0",
3535
"typedoc": "^0.28.14",
3636
"typescript": "^5.9.2",
37-
"typescript-eslint": "^8.50.0",
37+
"typescript-eslint": "^8.51.0",
3838
"vite": "^7.3.0",
3939
"vite-plugin-checker": "^0.12.0",
4040
"vite-plugin-dts": "^4.0.2",

packages/roslib/src/actionlib/SimpleActionServer.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -156,15 +156,9 @@ export default class SimpleActionServer<
156156
}
157157
} else {
158158
// treat id and stamp independently
159-
if (
160-
this.currentGoal &&
161-
cancelMessage.id === this.currentGoal.goal_id.id
162-
) {
159+
if (cancelMessage.id === this.currentGoal?.goal_id.id) {
163160
this.emit("cancel");
164-
} else if (
165-
this.nextGoal &&
166-
cancelMessage.id === this.nextGoal.goal_id.id
167-
) {
161+
} else if (cancelMessage.id === this.nextGoal?.goal_id.id) {
168162
this.nextGoal = null;
169163
}
170164

0 commit comments

Comments
 (0)