Make the code compatible with c++17 and disable clang-tidy warning

Author: bjsowa

.clang-tidy

@@ -1,14 +1,16 @@
 ---
-Checks: >
-  clang-analyzer-*,
-  -clang-analyzer-optin.cplusplus.VirtualCall,
-  clang-diagnostic-*,
-  google-*,
-  misc-*,
-  -misc-non-private-member-variables-in-classes,
-  readability-*,
-  -readability-identifier-length,
-  -readability-magic-numbers,
+Checks: [
+    clang-analyzer-*,
+    -clang-analyzer-optin.cplusplus.VirtualCall,
+    clang-diagnostic-*,
+    google-*,
+    misc-*,
+    -misc-non-private-member-variables-in-classes,
+    readability-*,
+    -readability-container-contains, # Removed for compatiblity with C++17 which is used in ROS Humble
+    -readability-identifier-length,
+    -readability-magic-numbers,
+  ]
 
 CheckOptions:
   misc-include-cleaner.IgnoreHeaders: bits/chrono.h
@@ -23,13 +25,13 @@ CheckOptions:
   readability-identifier-naming.StaticConstantCase: lower_case
   readability-identifier-naming.StaticVariableCase: lower_case
   readability-identifier-naming.MacroDefinitionCase: UPPER_CASE
-  readability-identifier-naming.MacroDefinitionIgnoredRegexp: '^[A-Z]+(_[A-Z]+)*_$'
+  readability-identifier-naming.MacroDefinitionIgnoredRegexp: "^[A-Z]+(_[A-Z]+)*_$"
   readability-identifier-naming.PrivateMemberCase: lower_case
   readability-identifier-naming.ProtectedMemberCase: lower_case
   readability-identifier-naming.PublicMemberCase: lower_case
   readability-identifier-naming.PrivateMemberSuffix: _
   readability-identifier-naming.ProtectedMemberSuffix: _
-  readability-identifier-naming.PublicMemberSuffix: ''
+  readability-identifier-naming.PublicMemberSuffix: ""
   readability-identifier-naming.NamespaceCase: lower_case
   readability-identifier-naming.ParameterCase: lower_case
   readability-identifier-naming.TypeAliasCase: CamelCase

src/web_video_server.cpp

@@ -204,7 +204,7 @@ bool WebVideoServer::handle_stream(
   const char * end)
 {
   const std::string type = request.get_query_param_value_or_default("type", default_stream_type_);
-  if (streamer_factories_.contains(type)) {
+  if (streamer_factories_.find(type) != streamer_factories_.end()) {
     const std::shared_ptr<StreamerInterface> streamer = streamer_factories_[type]->create_streamer(
       request, connection, weak_from_this());
     streamer->start();
@@ -223,7 +223,7 @@ bool WebVideoServer::handle_snapshot(
   const char * end)
 {
   const std::string type = request.get_query_param_value_or_default("type", default_snapshot_type_);
-  if (snapshot_streamer_factories_.contains(type)) {
+  if (snapshot_streamer_factories_.find(type) != snapshot_streamer_factories_.end()) {
     const std::shared_ptr<StreamerInterface> streamer =
       snapshot_streamer_factories_[type]->create_streamer(
       request, connection, weak_from_this());
@@ -243,7 +243,7 @@ bool WebVideoServer::handle_stream_viewer(
   const char * end)
 {
   const std::string type = request.get_query_param_value_or_default("type", default_stream_type_);
-  if (streamer_factories_.contains(type)) {
+  if (streamer_factories_.find(type) != streamer_factories_.end()) {
     const std::string topic = request.get_query_param_value_or_default("topic", "");
 
     async_web_server_cpp::HttpReply::builder(async_web_server_cpp::HttpReply::ok)