fix: resolve linting issues in .rcappsconfig implementation

Author: cursoragent

src/compiler/getAppSource.ts

@@ -7,9 +7,17 @@ import type {
     ICompilerFile,
     IMapCompilerFile,
 } from "../definition";
-import { readRcappsConfig, shouldIgnoreFile, type IRcappsConfig } from "../misc/rcappsConfigReader";
-
-async function walkDirectory(directory: string, projectPath: string, rcappsConfig: IRcappsConfig | null): Promise<ICompilerFile[]> {
+import {
+    readRcappsConfig,
+    shouldIgnoreFile,
+    type IRcappsConfig,
+} from "../misc/rcappsConfigReader";
+
+async function walkDirectory(
+    directory: string,
+    projectPath: string,
+    rcappsConfig: IRcappsConfig | null,
+): Promise<ICompilerFile[]> {
     const dirents = await fs.readdir(directory, { withFileTypes: true });
     const files = await Promise.all(
         dirents
@@ -24,7 +32,7 @@ async function walkDirectory(directory: string, projectPath: string, rcappsConfi
                 }
 
                 // Check if this path should be ignored based on .rcappsconfig
-                if (rcappsConfig && rcappsConfig.ignore) {
+                if (rcappsConfig?.ignore) {
                     if (shouldIgnoreFile(relativePath, rcappsConfig.ignore)) {
                         return null;
                     }
@@ -105,8 +113,12 @@ function getTypescriptFilesFromProject(
 export async function getAppSource(path: string): Promise<IAppSource> {
     // Load .rcappsconfig if it exists
     const rcappsConfig = await readRcappsConfig(path);
-    
-    const directoryWalkData: ICompilerFile[] = await walkDirectory(path, path, rcappsConfig);
+
+    const directoryWalkData: ICompilerFile[] = await walkDirectory(
+        path,
+        path,
+        rcappsConfig,
+    );
     const projectFiles: ICompilerFile[] = filterProjectFiles(
         path,
         directoryWalkData,

src/misc/rcappsConfigReader.ts

@@ -12,21 +12,25 @@ export interface IRcappsConfig {
  * @param projectPath The path to the project directory
  * @returns The parsed configuration or null if file doesn't exist
  */
-export async function readRcappsConfig(projectPath: string): Promise<IRcappsConfig | null> {
+export async function readRcappsConfig(
+    projectPath: string,
+): Promise<IRcappsConfig | null> {
     const configPath = path.join(projectPath, ".rcappsconfig");
-    
+
     try {
         const configContent = await fs.promises.readFile(configPath, "utf8");
         const config = JSON.parse(configContent) as IRcappsConfig;
-        
+
         logger.debug(`Loaded .rcappsconfig from ${configPath}`);
         return config;
     } catch (error) {
         if ((error as NodeJS.ErrnoException).code === "ENOENT") {
-            logger.debug("No .rcappsconfig file found, using default configuration");
+            logger.debug(
+                "No .rcappsconfig file found, using default configuration",
+            );
             return null;
         }
-        
+
         logger.warn(`Failed to parse .rcappsconfig file: ${error.message}`);
         return null;
     }
@@ -38,11 +42,14 @@ export async function readRcappsConfig(projectPath: string): Promise<IRcappsConf
  * @param config The .rcappsconfig configuration
  * @returns Combined ignore patterns
  */
-export function mergeIgnorePatterns(defaultIgnore: string[], config: IRcappsConfig | null): string[] {
-    if (!config || !config.ignore) {
+export function mergeIgnorePatterns(
+    defaultIgnore: string[],
+    config: IRcappsConfig | null,
+): string[] {
+    if (!config?.ignore) {
         return defaultIgnore;
     }
-    
+
     // Combine default ignore patterns with those from .rcappsconfig
     // .rcappsconfig patterns take precedence (are added last)
     return [...defaultIgnore, ...config.ignore];
@@ -54,16 +61,19 @@ export function mergeIgnorePatterns(defaultIgnore: string[], config: IRcappsConf
  * @param ignorePatterns Array of ignore patterns (glob-style)
  * @returns true if the file should be ignored
  */
-export function shouldIgnoreFile(filePath: string, ignorePatterns: string[]): boolean {
-    return ignorePatterns.some(pattern => {
+export function shouldIgnoreFile(
+    filePath: string,
+    ignorePatterns: string[],
+): boolean {
+    return ignorePatterns.some((pattern) => {
         // Support both glob patterns and simple directory/file names
         // Check for exact matches, basename matches, and path contains matches
         const normalizedPath = path.normalize(filePath).replace(/\\/g, "/");
         const normalizedPattern = pattern.replace(/\\/g, "/");
-        
+
         // Simple pattern matching - check if the pattern matches the path
         let isMatch = false;
-        
+
         // Exact match
         if (normalizedPath === normalizedPattern) {
             isMatch = true;
@@ -77,25 +87,32 @@ export function shouldIgnoreFile(filePath: string, ignorePatterns: string[]): bo
             isMatch = true;
         }
         // Glob-style patterns
-        else if (normalizedPattern.includes("*") || normalizedPattern.includes("?")) {
+        else if (
+            normalizedPattern.includes("*") ||
+            normalizedPattern.includes("?")
+        ) {
             // Convert simple glob pattern to regex
             const regexPattern = normalizedPattern
                 .replace(/\./g, "\\.")
                 .replace(/\*/g, ".*")
                 .replace(/\?/g, ".");
             try {
                 const regex = new RegExp(`^${regexPattern}$`);
-                isMatch = regex.test(normalizedPath) || regex.test(path.basename(normalizedPath));
+                isMatch =
+                    regex.test(normalizedPath) ||
+                    regex.test(path.basename(normalizedPath));
             } catch (e) {
                 // If regex fails, fall back to simple contains check
-                isMatch = normalizedPath.includes(normalizedPattern.replace(/\*/g, ""));
+                isMatch = normalizedPath.includes(
+                    normalizedPattern.replace(/\*/g, ""),
+                );
             }
         }
-        
+
         if (isMatch) {
             logger.debug(`File ${filePath} ignored by pattern: ${pattern}`);
         }
-        
+
         return isMatch;
     });
-}
+}

src/packager/AppPackager.ts

@@ -13,7 +13,11 @@ import type {
 } from "../definition";
 import { isBundled } from "../bundler";
 import logger from "../misc/logger";
-import { readRcappsConfig, mergeIgnorePatterns, type IRcappsConfig } from "../misc/rcappsConfigReader";
+import {
+    readRcappsConfig,
+    mergeIgnorePatterns,
+    type IRcappsConfig,
+} from "../misc/rcappsConfigReader";
 
 export class AppPackager {
     public static DefaultIgnorePatterns: string[] = [
@@ -29,6 +33,7 @@ export class AppPackager {
     ];
 
     private zip = new Yazl.ZipFile();
+
     private rcappsConfig: IRcappsConfig | null = null;
 
     constructor(
@@ -46,7 +51,10 @@ export class AppPackager {
             this.rcappsConfig = await readRcappsConfig(this.fd.folder);
         }
 
-        const ignorePatterns = mergeIgnorePatterns(AppPackager.DefaultIgnorePatterns, this.rcappsConfig);
+        const ignorePatterns = mergeIgnorePatterns(
+            AppPackager.DefaultIgnorePatterns,
+            this.rcappsConfig,
+        );
 
         return {
             dot: false,
@@ -146,7 +154,7 @@ export class AppPackager {
     // tslint:disable-next-line:promise-function-async
     private async asyncGlob(): Promise<Array<string>> {
         const globOptions = await this.getGlobOptions();
-        
+
         return new Promise((resolve, reject) => {
             glob(this.fd.toZip, globOptions, (err, matches) => {
                 if (err) {