Skip to content

Commit e29a6d0

Browse files
committed
fix: remove broken origin check and reset stale server filter
- Remove origin verification for credential reads (Pexip origin != RC server origin, check always fails — WebContents check is sufficient) - Reset persisted server filter when stored value no longer exists in available options, preventing empty log list with hidden control
1 parent 499d9fc commit e29a6d0

File tree

2 files changed

+8
-15
lines changed

2 files changed

+8
-15
lines changed

src/logViewerWindow/logViewerWindow.tsx

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,14 @@ function LogViewerWindow() {
179179
'all'
180180
);
181181

182+
// Reset persisted server filter if the stored value no longer exists
183+
useEffect(() => {
184+
const validKeys = serverFilterOptions.map(([key]) => key);
185+
if (!validKeys.includes(serverFilter)) {
186+
setServerFilter('all');
187+
}
188+
}, [serverFilter, serverFilterOptions, setServerFilter]);
189+
182190
const handleServerFilterChange = useCallback(
183191
(value: Key) => {
184192
setServerFilter(String(value));

src/videoCallWindow/ipc.ts

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1279,21 +1279,6 @@ handle('video-call-window/get-credentials', async (callerWebContents) => {
12791279
return null;
12801280
}
12811281

1282-
// Verify the caller's current page origin matches the stored server origin
1283-
try {
1284-
const callerOrigin = new URL(callerWebContents.getURL()).origin;
1285-
const storedOrigin = new URL(videoCallCredentials.serverUrl).origin;
1286-
if (callerOrigin !== storedOrigin) {
1287-
console.warn(
1288-
'Video call window: Credential request denied due to origin mismatch'
1289-
);
1290-
return null;
1291-
}
1292-
} catch {
1293-
// If URL parsing fails, deny access
1294-
return null;
1295-
}
1296-
12971282
return videoCallCredentials;
12981283
});
12991284

0 commit comments

Comments
 (0)