-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Open
Labels
type: featurePull requests that introduces new featurePull requests that introduces new feature
Description
Description:
Create a single tracking issue for all message-parser findings and PRs so maintainers can follow progress in one place, while keeping individual fixes in small mergeable PRs.
Steps to reproduce:
- Check message-parser issues/PRs opened over the last few days.
- Notice each finding is tracked as a separate issue without a parent tracker.
- It is harder to see overall progress, remaining scope, and rewrite readiness in one view.
Expected behavior:
A single umbrella issue exists with a checklist of all parser findings, each linked to its issue/PR and marked as done/in progress/pending.
Actual behavior:
Findings are currently spread across multiple separate issues/PRs, making consolidated progress tracking harder.
Server Setup Information:
- Version of Rocket.Chat Server: N/A (tracking/process issue)
- License Type: N/A
- Number of Users: N/A
- Operating System: N/A
- Deployment Method: N/A
- Number of Running Instances: N/A
- DB Replicaset Oplog: N/A
- NodeJS Version: N/A
- MongoDB Version: N/A
Client Setup Information
- Desktop App or Browser Version: N/A
- Operating System: N/A
Additional context
Tracking checklist:
Tracking checklist:
- Ordered list index
0lost inLIST_ITEMAST: issue Ordered list items with index 0 lose number field in message parser AST #39051, PR fix(message-parser): preserve ordered list index 0 in LIST_ITEM nodes #39052 (merged) - Hot-path allocation reductions in parser helpers: issue Performance bug: message parser hot-path helpers allocate excessive temporary arrays #39074, PR refactor: reduce hot-path allocations in message parser utils #39075 (merged)
- Timestamp test oracle decoupling from internals: issue Test bug: message-parser tests are oracle-coupled to production helpers #39085, PR test(message-parser): decouple parser tests from production helpers #39086 (merged)
- Related perf improvement (
reducePlainTexts): issue Performance: reducePlainTexts causes excessive allocations in message parser hot path #38900, PR refactor: make reducePlainTexts linear and allocation-light #38901 (merged) - ASTNode union completeness/type narrowing: issue Message parser ASTNode types are incomplete and break type narrowing for valid parser output #39057, PR chore(message-parser): align ASTNode union with parser output #39058 (open)
- Invalid absolute URL protocol-duplication handling: PR fix(message-parser): avoid protocol duplication for invalid absolute URLs #39293 (open)
- Simplify
Anyfallback URL/phone parsing path: PR refactor(message-parser): simplify Any fallback to reduce URL/phone parse attempts #39294 (open) - Parse-local skip flags refactor: PR refactor(message-parser): make skip flags parse-local #39477 (open)
- Tighten parser test assertions (
toMatchObject-> stricter structure): PR test(message-parser): tighten AST assertions #39438 (open)
Relevant logs:
N/A (tracking/process issue; no runtime logs required).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
type: featurePull requests that introduces new featurePull requests that introduces new feature