fix: prevent add prev_event or auth_events if the inital events are already informed (#248)

Author: ggazzo

packages/federation-sdk/src/services/state.service.ts

@@ -414,10 +414,9 @@ export class StateService {
 			event,
 			roomVersion,
 		);
-
 		await Promise.all([
-			this.addAuthEvents(instance),
-			this.addPrevEvents(instance),
+			instance.event.auth_events.length === 0 && this.addAuthEvents(instance),
+			instance.event.prev_events.length === 0 && this.addPrevEvents(instance),
 		]);
 		await this.signEvent(instance);
 

packages/room/src/manager/event-wrapper.ts

@@ -50,6 +50,9 @@ export abstract class PersistentEventBase<
 
 	protected rawEvent: PduWithHashesAndSignaturesOptional;
 
+	private authEventsIds: Set<EventID> = new Set();
+	private prevEventsIds: Set<EventID> = new Set();
+
 	constructor(
 		event: PduWithHashesAndSignaturesOptional,
 		public readonly version: Version,
@@ -58,6 +61,16 @@ export abstract class PersistentEventBase<
 		if (this.rawEvent.signatures) {
 			this.signatures = this.rawEvent.signatures;
 		}
+		if (this.rawEvent.auth_events) {
+			for (const id of this.rawEvent.auth_events) {
+				this.authEventsIds.add(id);
+			}
+		}
+		if (this.rawEvent.prev_events) {
+			for (const id of this.rawEvent.prev_events) {
+				this.prevEventsIds.add(id);
+			}
+		}
 	}
 
 	// don't recalculate the hash if it is already set
@@ -118,8 +131,8 @@ export abstract class PersistentEventBase<
 		const { hashes, signatures, ...event } = this.rawEvent;
 		return {
 			...event,
-			auth_events: Array.from(new Set([...this.rawEvent.auth_events])),
-			prev_events: Array.from(new Set([...this.rawEvent.prev_events])),
+			auth_events: Array.from(this.authEventsIds),
+			prev_events: Array.from(this.prevEventsIds),
 		};
 	}
 
@@ -143,11 +156,11 @@ export abstract class PersistentEventBase<
 	}
 
 	getAuthEventIds() {
-		return this.rawEvent.auth_events;
+		return Array.from(this.authEventsIds);
 	}
 
 	getPreviousEventIds() {
-		return this.rawEvent.prev_events;
+		return Array.from(this.prevEventsIds);
 	}
 
 	isState() {
@@ -419,15 +432,17 @@ export abstract class PersistentEventBase<
 	}
 
 	addPrevEvents(events: PersistentEventBase<Version>[]) {
-		this.rawEvent.prev_events.push(...events.map((e) => e.eventId));
+		for (const event of events) {
+			this.prevEventsIds.add(event.eventId);
+		}
 		if (this.rawEvent.depth <= events[events.length - 1].depth) {
 			this.rawEvent.depth = events[events.length - 1].depth + 1;
 		}
 		return this;
 	}
 
 	authedBy(event: PersistentEventBase<Version>) {
-		this.rawEvent.auth_events.push(event.eventId);
+		this.authEventsIds.add(event.eventId);
 		return this;
 	}