sets tip_chord as optional attr for Fins model; raises ValueError on unsupported fin kind

Author: GabrielBarberini

lib/models/aerosurfaces.py

@@ -1,4 +1,5 @@
 from enum import Enum
+from typing import Optional
 from pydantic import BaseModel
 
 
@@ -28,7 +29,7 @@ class Fins(BaseModel):
     name: str
     n: int
     root_chord: float
-    tip_chord: float
+    tip_chord: Optional[float]
     span: float
     position: float
     cant_angle: float

lib/services/rocket.py

@@ -176,16 +176,7 @@ def get_rocketpy_finset(fins: Fins, kind: str) -> RocketPyFins:
                     airfoil=fins.airfoil,
                 )
             case _:
-                rocketpy_finset = RocketPyTrapezoidalFins(
-                    n=fins.n,
-                    name=fins.name,
-                    tip_chord=fins.tip_chord,
-                    root_chord=fins.root_chord,
-                    span=fins.span,
-                    cant_angle=fins.cant_angle,
-                    rocket_radius=fins.radius,
-                    airfoil=fins.airfoil,
-                )
+                raise ValueError(f"Invalid fins kind: {kind}")
         rocketpy_finset.position = fins.position
         return rocketpy_finset