addresses PR review

Author: GabrielBarberini

pyproject.toml

@@ -55,6 +55,7 @@ disable = """
     no-member,
     protected-access,
     import-outside-toplevel,
+    too-many-statements,
 """
 
 [tool.ruff]

src/models/environment.py

@@ -1,8 +1,14 @@
-import datetime
+from datetime import datetime, timezone, timedelta
 from typing import Optional, ClassVar, Self, Literal
+from pydantic import Field
 from src.models.interface import ApiBaseModel
 
 
+def _default_future_datetime() -> datetime:
+    """Factory function to create timezone-aware datetime one day in the future."""
+    return datetime.now(timezone.utc) + timedelta(days=1)
+
+
 class EnvironmentModel(ApiBaseModel):
     NAME: ClassVar = 'environment'
     METHODS: ClassVar = ('POST', 'GET', 'PUT', 'DELETE')
@@ -20,9 +26,7 @@ class EnvironmentModel(ApiBaseModel):
         'ensemble',
     ] = 'standard_atmosphere'
     atmospheric_model_file: Optional[str] = None
-    date: Optional[datetime.datetime] = (
-        datetime.datetime.today() + datetime.timedelta(days=1)
-    )
+    date: Optional[datetime] = Field(default_factory=_default_future_datetime)
 
     @staticmethod
     def UPDATED():

src/utils.py

@@ -62,8 +62,14 @@ def rocketpy_encoder(obj, config: DiscretizeConfig = DiscretizeConfig()):
         Dictionary of encoded attributes
     """
 
-    # Create a copy to avoid mutating the original object
-    obj_copy = copy.deepcopy(obj)
+    if config is None:
+        config = DiscretizeConfig()
+    try:
+        # Create a copy to avoid mutating the original object
+        obj_copy = copy.deepcopy(obj)
+    except Exception:
+        # Fall back to a shallow copy if deep copy is not supported
+        obj_copy = copy.copy(obj)
 
     for attr_name in dir(obj_copy):
         if attr_name.startswith('_'):

src/views/environment.py

@@ -1,10 +1,15 @@
 from typing import Optional, Any
-from datetime import datetime, timedelta
-from pydantic import ConfigDict
+from datetime import datetime, timezone, timedelta
+from pydantic import ConfigDict, Field
 from src.views.interface import ApiBaseView
 from src.models.environment import EnvironmentModel
 
 
+def _default_future_datetime() -> datetime:
+    """Factory function to create timezone-aware datetime one day in the future."""
+    return datetime.now(timezone.utc) + timedelta(days=1)
+
+
 class EnvironmentSimulation(ApiBaseView):
     """
     Environment simulation view that handles dynamically
@@ -17,9 +22,7 @@ class EnvironmentSimulation(ApiBaseView):
     """
 
     model_config = ConfigDict(
-        ser_json_exclude_none=True,  # keep parent's behavior
-        extra='allow',
-        arbitrary_types_allowed=True
+        ser_json_exclude_none=True, extra='allow', arbitrary_types_allowed=True
     )
 
     message: str = "Environment successfully simulated"
@@ -41,9 +44,13 @@ class EnvironmentSimulation(ApiBaseView):
     initial_hemisphere: Optional[str] = None
     initial_ew: Optional[str] = None
     max_expected_height: Optional[int] = None
-    date: Optional[datetime] = datetime.today() + timedelta(days=1)
-    local_date: Optional[datetime] = datetime.today() + timedelta(days=1)
-    datetime_date: Optional[datetime] = datetime.today() + timedelta(days=1)
+    date: Optional[datetime] = Field(default_factory=_default_future_datetime)
+    local_date: Optional[datetime] = Field(
+        default_factory=_default_future_datetime
+    )
+    datetime_date: Optional[datetime] = Field(
+        default_factory=_default_future_datetime
+    )
 
     # Function attributes
     # discretized by rocketpy_encoder

src/views/flight.py

@@ -19,9 +19,7 @@ class FlightSimulation(RocketSimulation, EnvironmentSimulation):
     """
 
     model_config = ConfigDict(
-        ser_json_exclude_none=True,
-        extra='allow',
-        arbitrary_types_allowed=True
+        ser_json_exclude_none=True, extra='allow', arbitrary_types_allowed=True
     )
 
     message: str = "Flight successfully simulated"

src/views/motor.py

@@ -16,9 +16,7 @@ class MotorSimulation(ApiBaseView):
     """
 
     model_config = ConfigDict(
-        ser_json_exclude_none=True,
-        extra='allow',
-        arbitrary_types_allowed=True
+        ser_json_exclude_none=True, extra='allow', arbitrary_types_allowed=True
     )
 
     message: str = "Motor successfully simulated"

src/views/rocket.py

@@ -19,9 +19,7 @@ class RocketSimulation(MotorSimulation):
     """
 
     model_config = ConfigDict(
-        ser_json_exclude_none=True,
-        extra='allow',
-        arbitrary_types_allowed=True
+        ser_json_exclude_none=True, extra='allow', arbitrary_types_allowed=True
     )
 
     message: str = "Rocket successfully simulated"
@@ -30,7 +28,8 @@ class RocketSimulation(MotorSimulation):
     radius: Optional[float] = None
     mass: Optional[float] = None
     inertia: Optional[
-        tuple[float, float, float] | tuple[float, float, float, float, float, float]
+        tuple[float, float, float]
+        | tuple[float, float, float, float, float, float]
     ] = None
     power_off_drag: Optional[list[tuple[float, float]]] = None
     power_on_drag: Optional[list[tuple[float, float]]] = None