Skip to content

Commit eb3d79a

Browse files
addresses PR review
1 parent 0c1a979 commit eb3d79a

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

lib/models/environment.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ class AtmosphericModelTypes(str, Enum):
88
STANDARD_ATMOSPHERE: str = "STANDARD_ATMOSPHERE"
99
CUSTOM_ATMOSPHERE: str = "CUSTOM_ATMOSPHERE"
1010
WYOMING_SOUNDING: str = "WYOMING_SOUNDING"
11-
NOAARUCSOUNDING: str = "NOAARUCSOUNDING"
1211
FORECAST: str = "FORECAST"
1312
REANALYSIS: str = "REANALYSIS"
1413
ENSEMBLE: str = "ENSEMBLE"
@@ -17,7 +16,7 @@ class AtmosphericModelTypes(str, Enum):
1716
class Env(BaseModel):
1817
latitude: float
1918
longitude: float
20-
elevation: Optional[int] = None
19+
elevation: Optional[int] = 0
2120

2221
# Optional parameters
2322
atmospheric_model_type: Optional[AtmosphericModelTypes] = None

lib/models/motor.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@ class InterpolationMethods(str, Enum):
3131
LINEAR: str = "LINEAR"
3232
SPLINE: str = "SPLINE"
3333
AKIMA: str = "AKIMA"
34+
POLYNOMIAL: str = "POLYNOMIAL"
35+
SHEPARD: str = "SHEPARD"
36+
RBF: str = "RBF"
3437

3538

3639
class MotorTank(BaseModel):

lib/models/rocket.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,10 @@ class Rocket(BaseModel):
3131
mass: float
3232
motor_position: float
3333
center_of_mass_without_motor: int
34-
inertia: Tuple[float, float, float]
34+
inertia: Union[
35+
Tuple[float, float, float],
36+
Tuple[float, float, float, float, float, float],
37+
]
3538
power_off_drag: List[Tuple[float, float]]
3639
power_on_drag: List[Tuple[float, float]]
3740

lib/views/flight.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -151,8 +151,6 @@ class FlightSummary(RocketSummary, EnvSummary):
151151
z: Optional[Any]
152152
z_impact: Optional[Any]
153153
flight_phases: Optional[Any]
154-
FlightPhases: Optional[Any]
155-
TimeNodes: Optional[Any]
156154

157155
class Config:
158156
json_encoders = {Any: to_python_primitive}

0 commit comments

Comments
 (0)