DEV: custom atmosphere schema changes #55

aasitvora99 · 2025-07-13T15:51:21Z

Fixes #54

Summary by CodeRabbit

New Features
- Added support for specifying pressure, temperature, and wind parameters in environmental settings, allowing for more detailed atmospheric configuration.
Improvements
- Enhanced environmental simulation by increasing the precision of the maximum expected height attribute.

coderabbitai · 2025-07-13T15:51:27Z

"""

Walkthrough

The changes extend the EnvironmentModel to include optional atmospheric parameters (pressure, temperature, wind_u, wind_v) with flexible typing. The EnvironmentService now passes these new parameters to the underlying atmospheric model. Additionally, the type of max_expected_height in EnvironmentSimulation is updated from Optional[int] to Optional[float].

Changes

File(s)	Change Summary
src/models/environment.py	Added four optional attributes (`pressure`, `temperature`, `wind_u`, `wind_v`) to `EnvironmentModel` with flexible typing. Updated typing imports.
src/services/environment.py	Modified `from_env_model` to pass new atmospheric parameters to `set_atmospheric_model`.
src/views/environment.py	Changed `max_expected_height` type from `Optional[int]` to `Optional[float]` in `EnvironmentSimulation`.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant EnvironmentModel
    participant EnvironmentService
    participant RocketPyEnvironment

    User->>EnvironmentModel: Provide environment data (including pressure, temperature, wind_u, wind_v)
    EnvironmentModel->>EnvironmentService: Pass model instance
    EnvironmentService->>RocketPyEnvironment: set_atmospheric_model(type, file, pressure, temperature, wind_u, wind_v)

Assessment against linked issues

Objective (Issue #)	Addressed	Explanation
Extend environment class to support advanced model types and schema changes (#54)	✅

Assessment against linked issues: Out-of-scope changes

Code Change (file_path)	Explanation

Suggested reviewers

luimot
phmbressan

Poem

In the breeze where rockets fly,
New winds and temps now flutter by.
Pressure and gusts, all in the code,
Our models grow, the features flowed.
The sky's the limit, so let's cheer—
More power for the launch is here! 🚀🐇
"""

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between deda92e and 8854300.

📒 Files selected for processing (1)

src/models/environment.py (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/models/environment.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Analyze (python)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Copilot

Pull Request Overview

This PR updates the environment schema to support custom atmospheric inputs and standardizes the height type.

Changed max_expected_height from int to float in the simulation view
Extended the EnvironmentModel to include pressure, temperature, wind_u, and wind_v fields
Passed the new parameters into the rocketpy_env.set_atmospheric_model call

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/views/environment.py	Updated `max_expected_height` annotation from `int` to `float`
src/models/environment.py	Added `pressure`, `temperature`, `wind_u`, and `wind_v` fields
src/services/environment.py	Propagated new atmospheric parameters into model initializer

Comments suppressed due to low confidence (3)

src/services/environment.py:34

There are no tests covering the new custom atmospheric parameters (pressure, temperature, wind_u, wind_v) being passed into set_atmospheric_model. Consider adding unit tests for these new flows.

            pressure=env.pressure,

src/views/environment.py:25

Changing max_expected_height from int to float may introduce type inconsistencies in downstream logic; ensure all consumers handle float values properly or update related validation and documentation.

    max_expected_height: Optional[float] = None

src/services/environment.py:34

Consider validating or providing default handling for env.pressure (and the other new parameters) before passing them to set_atmospheric_model to avoid unexpected None values at runtime.

            pressure=env.pressure,

Copilot · 2025-07-13T15:52:01Z

src/models/environment.py

+    pressure: Optional[float | List[Tuple[float, float]]] = None
+    temperature: Optional[float | List[Tuple[float, float]]] = None
+    wind_u: Optional[float | List[Tuple[float, float]]] = None
+    wind_v: Optional[float | List[Tuple[float, float]]] = None


[nitpick] The union type annotation using typing.List and typing.Tuple can be simplified with built-in generics (e.g., list[tuple[float, float]]) for consistency with modern Python syntax.

Suggested change

pressure: Optional[float | List[Tuple[float, float]]] = None

temperature: Optional[float | List[Tuple[float, float]]] = None

wind_u: Optional[float | List[Tuple[float, float]]] = None

wind_v: Optional[float | List[Tuple[float, float]]] = None

pressure: Optional[float | list[tuple[float, float]]] = None

temperature: Optional[float | list[tuple[float, float]]] = None

wind_u: Optional[float | list[tuple[float, float]]] = None

wind_v: Optional[float | list[tuple[float, float]]] = None

Its totally a minor but I dont see why to stick with the old hinting since we keep python very updated for infinity.

Wdyt @aasitvora99 ?

didn't realize this was a thing in Python. fixed with 8854300

GabrielBarberini

LGTM

Just make sure to make format, make lint and make test then merge it

Gui-FernandesBR

lgtm

DEV: custom atmosphere schema changes

9b1afd6

aasitvora99 requested review from GabrielBarberini and Copilot July 13, 2025 15:51

aasitvora99 self-assigned this Jul 13, 2025

Copilot AI reviewed Jul 13, 2025

View reviewed changes

GabrielBarberini previously approved these changes Jul 13, 2025

View reviewed changes

Gui-FernandesBR previously approved these changes Jul 14, 2025

View reviewed changes

MNT: formatting

deda92e

aasitvora99 dismissed stale reviews from Gui-FernandesBR and GabrielBarberini via deda92e July 14, 2025 04:55

MNT: refactor to use inbuilt generics

8854300

aasitvora99 requested review from GabrielBarberini and Gui-FernandesBR July 14, 2025 05:03

GabrielBarberini approved these changes Jul 14, 2025

View reviewed changes

aasitvora99 merged commit b3f1ede into master Jul 14, 2025
4 checks passed

aasitvora99 deleted the enh/environment-models branch July 14, 2025 20:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

DEV: custom atmosphere schema changes #55

DEV: custom atmosphere schema changes #55

Uh oh!

aasitvora99 commented Jul 13, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 13, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 13, 2025

Uh oh!

GabrielBarberini Jul 13, 2025

Uh oh!

aasitvora99 Jul 14, 2025

Uh oh!

GabrielBarberini left a comment

Uh oh!

Gui-FernandesBR left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

DEV: custom atmosphere schema changes #55

DEV: custom atmosphere schema changes #55

Uh oh!

Conversation

aasitvora99 commented Jul 13, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

GabrielBarberini Jul 13, 2025

Choose a reason for hiding this comment

Uh oh!

aasitvora99 Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

GabrielBarberini left a comment

Choose a reason for hiding this comment

Uh oh!

Gui-FernandesBR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aasitvora99 commented Jul 13, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 13, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)