Skip to content

Commit 535104b

Browse files
committed
MNT: removing property from rocket.py poitmassrocket
- MNT: properties which are similar to attributes are not needed were removed from pointmassrocket - MNT: removing default set values for attributes for pointmassrocket
1 parent 497e6a2 commit 535104b

File tree

1 file changed

+5
-31
lines changed

1 file changed

+5
-31
lines changed

rocketpy/rocket/rocket.py

Lines changed: 5 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -2114,11 +2114,11 @@ class PointMassRocket(Rocket):
21142114
"""
21152115
def __init__(
21162116
self,
2117-
radius: float = 0.05,
2118-
mass: float = 0,
2119-
center_of_mass_without_motor: float = 0,
2120-
power_off_drag: float = 0.4,
2121-
power_on_drag: float = 0.4,
2117+
radius: float,
2118+
mass: float,
2119+
center_of_mass_without_motor: float,
2120+
power_off_drag: float,
2121+
power_on_drag: float,
21222122
):
21232123
self._center_of_mass_without_motor_pointmass = center_of_mass_without_motor
21242124
self._center_of_dry_mass_position = center_of_mass_without_motor
@@ -2141,29 +2141,3 @@ def __init__(
21412141
center_of_mass_without_motor=center_of_mass_without_motor,
21422142
)
21432143

2144-
# ------------------------------------------------------------------
2145-
# Center of Mass Properties
2146-
# ------------------------------------------------------------------
2147-
@property
2148-
def center_of_mass_without_motor(self):
2149-
return self._center_of_mass_without_motor_pointmass
2150-
2151-
@center_of_mass_without_motor.setter
2152-
def center_of_mass_without_motor(self, value):
2153-
self._center_of_mass_without_motor_pointmass = value
2154-
2155-
@property
2156-
def center_of_dry_mass_position(self):
2157-
return self._center_of_dry_mass_position
2158-
2159-
@center_of_dry_mass_position.setter
2160-
def center_of_dry_mass_position(self, value):
2161-
self._center_of_dry_mass_position = value
2162-
2163-
@property
2164-
def center_of_mass(self):
2165-
return self._center_of_mass
2166-
2167-
@center_of_mass.setter
2168-
def center_of_mass(self, value):
2169-
self._center_of_mass = value

0 commit comments

Comments
 (0)