Skip to content

Commit f926264

Browse files
committed
DOC: Solve review comments of dev docs.
1 parent b257dbf commit f926264

File tree

5 files changed

+55
-30
lines changed

5 files changed

+55
-30
lines changed

docs/development/conflicts.rst

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ It creates a new commit that marks the merging of the two branches together.
2525

2626
**Rebase**
2727

28-
The `rebase` operation integrates changes from one branch into another by replaying \
28+
The `rebase` operation integrates changes from one branch into another by reapplying \
2929
the commits on top of the target branch. It results in a more linear history.
3030

3131
* Produces a cleaner, linear commit history.
@@ -81,8 +81,12 @@ When to Use Merge or Rebase
8181
~~~~~~~~~~~~~~~~~~~~~~~~~~~
8282

8383
Generally, the maintainers will inform you which operation to use when merging your PR. \
84-
Notice that there is no wrong way to merge branches, but it is important to avoid letting \
85-
conflicts accumulate, since they can become harder to resolve.
84+
Notice that there is no wrong way to merge branches, but ``rebase`` is usually preferred \
85+
to keep a more linear history.
86+
87+
Furthermore, it is important to avoid letting conflicts accumulate, since they can become \
88+
harder to resolve. It is recommended to update your feature branch frequently with the latest \
89+
changes from the branch it was branched off.
8690

8791
Solving Conflicts
8892
-----------------
@@ -111,7 +115,7 @@ When a conflict occurs, VS Code will open the *Merge Editor* to help you resolve
111115
2. The *Merge Editor* will show the conflicting sections side by side.
112116
3. Click on the `Accept Current Change` or `Accept Incoming Change` buttons to keep the desired changes, sometimes both changes will be kept or even a manual edit will be necessary.
113117

114-
More details on VS Code interface ans conflict solver can be found in `VS Code Docs <https://code.visualstudio.com/docs/sourcecontrol/overview#_3way-merge-editor>`_.
118+
More details on VS Code interface and conflict solver can be found in `VS Code Docs <https://code.visualstudio.com/docs/sourcecontrol/overview#_3way-merge-editor>`_.
115119
After resolving the conflicts, save the files, make sure all conflicts are resolved, and then \
116120
commit the changes.
117121

docs/development/first_pr.rst

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,13 +51,25 @@ Your branch name should follow the guidelines described in :doc:`/development/st
5151
Opening the PR
5252
--------------
5353

54+
After you finish your work, you are more than welcome opening a PR to the RocketPy repository.
55+
Here are some checks to do before opening a PR:
56+
57+
* Check if the test suite is passing.
58+
* Format your code using ``black`` and ``isort``.
59+
60+
Check the :doc:`/development/pro_tips` section for more information on how to run these commands.
61+
5462
When you open a PR, you should:
5563

5664
* Use labels to help maintainers understand what the PR is about.
5765
* Link any issue that may be closed when the PR is merged.
5866

5967
Remember, the PR is yours, not ours! You should keep track of it and update it as needed.
6068

69+
.. important::
70+
71+
See the :doc:`/development/style_guide` for more information on how to name and \
72+
describe your PR.
6173

6274
Continuous Integration (CI)
6375
---------------------------

docs/development/pro_tips.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ Code assistance
5656
Artificial Intelligence (AI) assistance has becoming more and more common in
5757
software development.
5858
Some editors have AI assistance built-in.
59-
Famous options are GitHub Copilot, and
59+
Famous options are GitHub Copilot, JetBrains AI and TabNine.
6060

6161
At this repo, the use of AI tools is welcome, we don't have any restrictions
6262
against it.

docs/development/setting_up.rst

Lines changed: 22 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ There are different ways to do this, but most of them will involve the following
3535
git clone
3636
3737
38-
...
39-
38+
After cloning the repository, you will have a copy of the RocketPy repository on your \
39+
local machine and, by default, you will be on the ``master`` branch.
4040

4141
.. tip::
4242

@@ -48,6 +48,26 @@ There are different ways to do this, but most of them will involve the following
4848
repository and the remote repository. This connection allows you to push and \
4949
pull changes between the two repositories.
5050

51+
Navigating through the project
52+
------------------------------
53+
54+
In order to work on your local repository, you will need to open the directory where you \
55+
cloned it. We recommend using VS Code as your editor, but you can use any editor you prefer.
56+
If you are using VS Code, you can open the project by running the following command:
57+
58+
.. code-block:: console
59+
60+
code <path/to/your/folder>
61+
62+
After opening the project for the first time, you will be at the ``master`` branch.
63+
To switch to another branch, such as the ``develop`` branch, you will need to fetch \
64+
it from the remote repository and then checkout to it.
65+
66+
.. code-block:: console
67+
68+
git fetch origin develop
69+
git checkout develop
70+
5171
5272
Installation
5373
------------
@@ -64,27 +84,6 @@ development requirements:
6484
pip install -r requirements-tests.txt # install test/dev requirements
6585
6686
67-
Navigating through the project
68-
------------------------------
69-
70-
Opening your editor:
71-
72-
.. code-block:: console
73-
74-
code <path/to/your/folder>
75-
76-
Moving to a different branch:
77-
78-
.. code-block:: console
79-
80-
git checkout ...
81-
82-
83-
Running a flight simulation
84-
---------------------------
85-
86-
Please see the other page... (link the other page)
87-
8887
Running the tests
8988
-----------------
9089

docs/development/style_guide.rst

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ Running these commands before submitting a pull request is also highly recommend
6363

6464
.. code-block:: bash
6565
66+
make format
6667
make flake8
6768
make pylint
6869
@@ -71,8 +72,6 @@ The ``flake8`` command will throw a report directly to the console, while the
7172
``pylint`` command will create a ``.pylint_report.txt`` file in the root directory,
7273
which you can open to see the report.
7374

74-
75-
7675
Documentation Style
7776
-------------------
7877

@@ -164,6 +163,17 @@ Pull Requests
164163
^^^^^^^^^^^^^
165164

166165
When opening a Pull Request, the name of the PR should be clear and concise.
166+
Similarly to the commit messages, the PR name should start with an acronym indicating the type of PR
167+
and then a brief description of the changes.
168+
169+
Here is an example of a good PR name:
170+
171+
- ``BUG: fix the Frequency Response plot of the Flight class``
172+
173+
The PR description explain the changes and motivation behind them. There is a template \
174+
available when opening a PR that can be used to guide you through the process of both \
175+
describing the changes and making sure all the necessary steps were taken. Of course, \
176+
you can always modify the template or add more information if you think it is necessary.
167177

168178

169179

0 commit comments

Comments
 (0)