Skip to content

BUG: Initialize _Controller Init Parameters #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 9, 2024
Merged

BUG: Initialize _Controller Init Parameters #703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f06c4c2
BUG: add rail buttons checks in add_surfaces
MateusStano Oct 3, 2024
973eda1
BUG: restart rail buttons components
MateusStano Oct 3, 2024
0777612
BUG: save initial_observed_variables on self
MateusStano Oct 6, 2024
ddbccb3
ENH: create self.base_controller_function
MateusStano Oct 6, 2024
438bf90
Merge branch 'develop' into bug/init-variables-save-on-self
Gui-FernandesBR Oct 9, 2024
5aee235
DEV: updates changelog
Gui-FernandesBR Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ Attention: The newest changes should be on top -->

### Fixed

- BUG: Initialize _Controller Init Parameters [#703](https://github.com/RocketPy-Team/RocketPy/pull/703)
- BUG: Rail Buttons Not Accepted in Add Surfaces [#701](https://github.com/RocketPy-Team/RocketPy/pull/701)
- BUG: Vector encoding breaks MonteCarlo export. [#704](https://github.com/RocketPy-Team/RocketPy/pull/704)
- BUG: Single Point Functions Can Not Be Defined [#700](https://github.com/RocketPy-Team/RocketPy/pull/700)
Expand Down
2 changes: 2 additions & 0 deletions rocketpy/control/controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,10 @@ def __init__(
None
"""
self.interactive_objects = interactive_objects
self.base_controller_function = controller_function
Copy link
Member

@Gui-FernandesBR Gui-FernandesBR Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MateusStano I have no idea why you want to save this attribute as base_controller_functioninstead of simply controller_function. I'm approving this since the class is still private.

self.controller_function = self.__init_controller_function(controller_function)
self.sampling_rate = sampling_rate
self.initial_observed_variables = initial_observed_variables
self.name = name
self.prints = _ControllerPrints(self)

Expand Down
Loading