Skip to content

Conversation

@Gui-FernandesBR
Copy link
Member

Pull request type

  • Code maintenance (refactoring, formatting, tests)

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

image

Breaking change

  • No

Additional information

Unfortunately, there's no workaround to get these data again, since the governamental agency (NOAA) decided to no longer expose the model to the public.

@codecov
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.88%. Comparing base (b9b44dd) to head (1f4c61b).
Report is 14 commits behind head on develop.

Files with missing lines Patch % Lines
rocketpy/environment/environment.py 0.00% 1 Missing ⚠️
rocketpy/environment/fetchers.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #706      +/-   ##
===========================================
- Coverage    76.02%   75.88%   -0.14%     
===========================================
  Files           99       99              
  Lines        11278    11221      -57     
===========================================
- Hits          8574     8515      -59     
- Misses        2704     2706       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gui-FernandesBR Gui-FernandesBR force-pushed the dep/remove-noaas-ruc-sounding branch from 0f0be1c to 767311c Compare October 9, 2024 01:47
@Gui-FernandesBR Gui-FernandesBR merged commit 8fa8f4c into develop Oct 9, 2024
6 of 8 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the dep/remove-noaas-ruc-sounding branch October 9, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

2 participants