BUG: Fix Motor Zero Dry Mass Check #710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gui-FernandesBR
approved these changes
Oct 9, 2024
Member
Gui-FernandesBR
left a comment
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Please wait for the tests on CI,
Please update the CHANGELOG.
The setter is not checking for negative mass values. I understand it's not the focus of this PR. We can improve it in the future.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #710 +/- ##
===========================================
+ Coverage 75.90% 75.93% +0.02%
===========================================
Files 99 99
Lines 11222 11222
===========================================
+ Hits 8518 8521 +3
+ Misses 2704 2701 -3 ☔ View full report in Codecov by Sentry. |
phmbressan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed zero mass check for motor dry_mass. Local tests are passing.