Skip to content

Conversation

@leogrosa
Copy link
Member

@leogrosa leogrosa commented Dec 6, 2024

Pull request type

  • Other (please describe): Added a flight example

Checklist

  • Docs have been reviewed and added / updated
  • All tests (pytest tests -m slow --runslow) have passed locally

Current behavior

Behaves as expected. No flight example related to the Vetor II Project was available previously.

New behavior

Behaves as expected. Introduced a new flight example based on the Vetor II Project from UEL (Universidade Estadual de Londrina).

Breaking change

  • Yes
  • No

Additional information

The Vetor II flight example doesn't have actual flight data for a complete analysis, but it does have a motor, test bench (thrust data), a vehicle structure, and internal tools that made the example possible.

@leogrosa leogrosa requested a review from a team as a code owner December 6, 2024 06:38
@Gui-FernandesBR Gui-FernandesBR changed the base branch from master to develop December 6, 2024 09:55
@codecov
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.45%. Comparing base (e1a2061) to head (d68dd00).
Report is 26 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #747      +/-   ##
===========================================
+ Coverage    75.99%   76.45%   +0.46%     
===========================================
  Files           95       95              
  Lines        11015    11078      +63     
===========================================
+ Hits          8371     8470      +99     
+ Misses        2644     2608      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leogrosa
Copy link
Member Author

leogrosa commented Dec 6, 2024

It seems the CI/CD pipeline failed to trigger due to a configuration issue (No event triggers defined in on). Could you please check if the workflows are properly set to run on pull requests? Please let me know if there's anything I should adjust.

@Gui-FernandesBR
Copy link
Member

It seems the CI/CD pipeline failed to trigger due to a configuration issue (No event triggers defined in on). Could you please check if the workflows are properly set to run on pull requests? Please let me know if there's anything I should adjust.

The CI is working properly.

When receiving contributions from external users, we have to manually trigger the CI execution. This is important so we don't execute malicious code.

Thanks for your contribution!

@leogrosa
Copy link
Member Author

leogrosa commented Dec 6, 2024

Ok, thanks!
This PR is my challenge submission for the 2024 RocketPy Recruitment Process. I hope it serves as a valuable contribution :)

@Gui-FernandesBR
Copy link
Member

Ok, thanks! This PR is my challenge submission for the 2024 RocketPy Recruitment Process. I hope it serves as a valuable contribution :)

Yes, it definitely does. Thank you so much! You will be hearing from us quite soon;

@Gui-FernandesBR
Copy link
Member

@leogrosa your PR looks great and it does add a valuable contribution to this project.
However, since the rocket was not launched yet, and therefore you don't have real flight data to compare your simulations to, we decide to not proceed with this PR, specially given that our focus with the filghts examples is to provide simulations performance to new users.

I'm completely sure you're going to find another issue to become your first contribution to this project, you're 100% capable of.

Thank you so much!

@leogrosa
Copy link
Member Author

Thanks for the feedback, @Gui-FernandesBR! It makes perfect sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

2 participants