BUG: LSODA solver not being detected correctly. #807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #807 +/- ##
==========================================
+ Coverage 79.11% 79.14% +0.03%
==========================================
Files 96 96
Lines 11575 11573 -2
==========================================
+ Hits 9158 9160 +2
+ Misses 2417 2413 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6 tasks
MateusStano
previously approved these changes
Apr 21, 2025
phmbressan
force-pushed
the
bug/overshootable-sims
branch
from
9f573ba to
dc582de
Compare
phmbressan
force-pushed
the
bug/overshootable-sims
branch
from
dc582de to
a23f60e
Compare
github-project-automation
bot
moved this from Backlog
to Next Version
in LibDev Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
pytest tests -m slow --runslow) have passed locallyNote: Non-related
MonteCarlotests have failed. I am investigating it.CHANGELOG.mdhas been updated (if relevant)Current behavior
A bug introduced by yours truly on PR #748 causes the simulation solver not detect correctly when using
LSODAsolver. This is crucial when performing non-overshootable simulations.New behavior
This PR fixes the issue by correctly detecting the usage of
LSODA.Breaking change
Additional information
This could have been detected earlier had the
--runslowtests been executed more often.