BUG: Fix the handling of reference pressure for older rpy files. #808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phmbressan
commented
Apr 21, 2025
|
|
||
| return json.dumps(outputs_dict, cls=RocketPyEncoder) + "\n" | ||
| return ( | ||
| json.dumps(outputs_dict, cls=RocketPyEncoder, **self._export_config) + "\n" |
Collaborator
Author
There was a problem hiding this comment.
This change had already been done by PR #679, however is was likely undone by merging errors at some point.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #808 +/- ##
===========================================
+ Coverage 79.11% 79.79% +0.67%
===========================================
Files 96 97 +1
Lines 11575 11899 +324
===========================================
+ Hits 9158 9495 +337
+ Misses 2417 2404 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-project-automation
bot
moved this from Backlog
to Next Version
in LibDev Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
make format) has passed locallypytest tests -m slow --runslow) have passed locally--runslowneeds BUG: LSODA solver not being detected correctly. #807 and Bug: Fix StochasticFlight time_overshoot None bug #805CHANGELOG.mdhas been updated (if relevant)Current behavior
Currently, the introduction of
net_thrustis the first addition of an attribute that impacts the behavior of the motor and flight classes. Therefore, the.rpyof version 1.8.0 does not have this parameters, which should be handled.One notable point is that the tests are working as expected and caught this "file breaking change".
New behavior
This PR adds custom handling for the new attributes. Unfortunately, I did not find other ways beside manual handling (i.e. pinpointing in code the necessary attribute).
I am open to suggestions on how to deal with those parameter changes between older file versions.
Breaking change