-
-
Notifications
You must be signed in to change notification settings - Fork 208
MNT: fix deprecations and warnings #829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8e2824a to
cb62905
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR cleans up deprecated functionality and warning messages while updating some API calls to reflect recent changes. Key changes include:
- Removal of deprecated functions and attributes (e.g. post_process in Flight and create_dispersion_dictionary in utilities).
- Updated warning calls (now including explicit warning categories) and consistent API usage (e.g. using geodesic_to_utm/utm_to_geodesic from the tools module).
- Minor improvements such as correcting typographical errors and updating visualization parameters.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/test_environment.py | Updated coordinate conversion calls to use functions imported from the tools module. |
| tests/acceptance/test_bella_lui_rocket.py | Removed call to the deprecated Flight.post_process method. |
| rocketpy/utilities.py | Deprecated create_dispersion_dictionary function removed. |
| rocketpy/simulation/flight.py | Removed deprecated post_process method and attribute; updated warnings to include UserWarning. |
| rocketpy/rocket/aero_surface/air_brakes.py | Updated warning call to use explicit warning category. |
| rocketpy/plots/monte_carlo_plots.py | Changed boxplot parameter from “vert” to “orientation” for clarity and compatibility. |
| rocketpy/motors/motor.py | Corrected a spelling error in the docstring (“vaccum” ➔ “vacuum”). |
| rocketpy/environment/environment.py | Removed deprecated static methods; updated calls to use new tools module functions. |
| CHANGELOG.md | Updated changelog entry to reflect the maintenance changes. |
Comments suppressed due to low confidence (5)
tests/acceptance/test_bella_lui_rocket.py:184
- Call to deprecated method post_process has been removed; please verify that the test still validates all necessary flight data without relying on this method.
)
rocketpy/motors/motor.py:1153
- Correct the spelling of 'vaccum' to 'vacuum' in the docstring.
vacuum_thrust : Function
rocketpy/environment/environment.py:2523
- The deprecated static methods for geodesic and UTM conversions have been removed; ensure that all client code now references the new implementations in the tools module.
) from e
tests/unit/test_environment.py:9
- Ensure that the updated import from the tools module aligns with the new API design for coordinate conversions across the codebase.
from rocketpy.environment.tools import geodesic_to_utm, utm_to_geodesic
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #829 +/- ##
===========================================
+ Coverage 79.11% 80.02% +0.90%
===========================================
Files 96 98 +2
Lines 11575 12004 +429
===========================================
+ Hits 9158 9606 +448
+ Misses 2417 2398 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…future Python versions
* MNT: update code and remove deprecated functions * MNT: simplify geodesic_to_utm import and usage in Environment class * MNT: update CHANGELOG to fix deprecations and warnings * make lint * MNT: remove unused post_processed attribute from Flight class * MNT: update matplotlib version to 3.8.3 in requirements.txt * MNT: update matplotlib version to 3.10.0 in requirements.txt * MNT: downgrade matplotlib version to 3.9.0 in requirements.txt * MNT: change boxplot orientation to horizontal for compatibility with future Python versions * MNT: change boxplot orientation from horizontal to vertical for consistency
No description provided.