Skip to content

Conversation

@Gui-FernandesBR
Copy link
Member

No description provided.

This comment was marked as outdated.

@Gui-FernandesBR Gui-FernandesBR changed the base branch from master to develop June 17, 2025 02:20
@github-project-automation github-project-automation bot moved this from Backlog to Next Version in LibDev Roadmap Jun 18, 2025
@Gui-FernandesBR Gui-FernandesBR requested a review from Copilot June 20, 2025 00:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up deprecated functionality and warning messages while updating some API calls to reflect recent changes. Key changes include:

  • Removal of deprecated functions and attributes (e.g. post_process in Flight and create_dispersion_dictionary in utilities).
  • Updated warning calls (now including explicit warning categories) and consistent API usage (e.g. using geodesic_to_utm/utm_to_geodesic from the tools module).
  • Minor improvements such as correcting typographical errors and updating visualization parameters.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/unit/test_environment.py Updated coordinate conversion calls to use functions imported from the tools module.
tests/acceptance/test_bella_lui_rocket.py Removed call to the deprecated Flight.post_process method.
rocketpy/utilities.py Deprecated create_dispersion_dictionary function removed.
rocketpy/simulation/flight.py Removed deprecated post_process method and attribute; updated warnings to include UserWarning.
rocketpy/rocket/aero_surface/air_brakes.py Updated warning call to use explicit warning category.
rocketpy/plots/monte_carlo_plots.py Changed boxplot parameter from “vert” to “orientation” for clarity and compatibility.
rocketpy/motors/motor.py Corrected a spelling error in the docstring (“vaccum” ➔ “vacuum”).
rocketpy/environment/environment.py Removed deprecated static methods; updated calls to use new tools module functions.
CHANGELOG.md Updated changelog entry to reflect the maintenance changes.
Comments suppressed due to low confidence (5)

tests/acceptance/test_bella_lui_rocket.py:184

  • Call to deprecated method post_process has been removed; please verify that the test still validates all necessary flight data without relying on this method.
    )

rocketpy/motors/motor.py:1153

  • Correct the spelling of 'vaccum' to 'vacuum' in the docstring.
        vacuum_thrust : Function

rocketpy/environment/environment.py:2523

  • The deprecated static methods for geodesic and UTM conversions have been removed; ensure that all client code now references the new implementations in the tools module.
            ) from e

tests/unit/test_environment.py:9

  • Ensure that the updated import from the tools module aligns with the new API design for coordinate conversions across the codebase.
from rocketpy.environment.tools import geodesic_to_utm, utm_to_geodesic

@codecov
Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.02%. Comparing base (4df0b38) to head (b54c87f).
Report is 24 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #829      +/-   ##
===========================================
+ Coverage    79.11%   80.02%   +0.90%     
===========================================
  Files           96       98       +2     
  Lines        11575    12004     +429     
===========================================
+ Hits          9158     9606     +448     
+ Misses        2417     2398      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Gui-FernandesBR Gui-FernandesBR merged commit 0f6c701 into develop Jun 20, 2025
10 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the mnt/deprecations branch June 20, 2025 06:50
@github-project-automation github-project-automation bot moved this from Next Version to Closed in LibDev Roadmap Jun 20, 2025
aZira371 pushed a commit to aZira371/RocketPy that referenced this pull request Sep 9, 2025
* MNT: update code and remove deprecated functions

* MNT: simplify geodesic_to_utm import and usage in Environment class

* MNT: update CHANGELOG to fix deprecations and warnings

* make lint

* MNT: remove unused post_processed attribute from Flight class

* MNT: update matplotlib version to 3.8.3 in requirements.txt

* MNT: update matplotlib version to 3.10.0 in requirements.txt

* MNT: downgrade matplotlib version to 3.9.0 in requirements.txt

* MNT: change boxplot orientation to horizontal for compatibility with future Python versions

* MNT: change boxplot orientation from horizontal to vertical for consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

3 participants