-
-
Notifications
You must be signed in to change notification settings - Fork 208
Enh/acceleration earth to rocket frame #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
gdilbaz
wants to merge
12
commits into
RocketPy-Team:develop
from
gdilbaz:enh/acceleration-earth-to-rocket-frame
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3479bda
Merge pull request #819 from RocketPy-Team/develop
Lucas-Prates c0b052b
REL: update to v1.10.0
Lucas-Prates dac0934
REL: update to v1.10.0
Lucas-Prates 809b7e0
BUG: fix version comparison bug in utilities test
Lucas-Prates 376ff96
Merge pull request #821 from RocketPy-Team/rel/v1.10.0
Lucas-Prates b559c59
Update README.md
GabrielBarberini 2655a4f
Merge pull request #824 from RocketPy-Team/deepwiki
GabrielBarberini acad418
ENH: See #529 changed the name in order to prevent confusion
gdilbaz 9cc930c
Merge branch 'develop' into enh/acceleration-earth-to-rocket-frame
gdilbaz c2e611d
Delete monte_carlo_test.outputs.txt
gdilbaz 3d3f066
Delete monte_carlo_test.inputs.txt
gdilbaz 6e812e2
Delete monte_carlo_test.errors.txt
gdilbaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of coding, it is quite fine to me already.
I would just say that we need to implement unit tests for this method before merging.
@MateusStano, what do you think in terms of physics/dynamics? Anything to comment on?