Skip to content

Conversation

@uniKorqi422
Copy link

@uniKorqi422 uniKorqi422 commented Oct 13, 2025

Pull request type

  • Code changes (bugfix, features)
  • Code maintenance (refactoring, formatting, tests)
  • ReadMe, Docs and GitHub updates
  • Other (please describe):

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Current behavior

requirements.txt reflected an outdated venv setup, lacking netCDF4-1.7.2 and other dependencies for weather modeling.

New behavior

Updated requirements.txt to match venv setup with netCDF4-1.7.2, numpy-2.3.3, and more, enabling Wyoming sounding integration. Lays groundwork for my long-term vision: IMAP-driven drag adjustments to simulate and protect SpaceX satellite environments. This update ensures compatibility with netCDF4-1.7.2 for Wyoming sounding data, a stepping stone toward IMAP satellite drag simulations. The venv setup supports environmental modeling with RocketPy’s Environment class, aiming to enhance satellite orbit simulations by integrating real atmospheric data.

Breaking change

  • Yes
  • No

Additional information

Tested locally with Python 3.14.0. Open to feedback on aligning this with RocketPy’s trajectory tools. Screenshots of venv setup available if needed!

@Gui-FernandesBR
Copy link
Member

@uniKorqi422 , I'm sorry but this PR doesn't seem to make enough of sense. If you simply remove the requerements... How are we suppose to download and install rocketpy? Tests are not passing on CI due to this reason.

Please feel free to propose a different PR or to push to this branch again - re-opening the PR.

@github-project-automation github-project-automation bot moved this from Backlog to Closed in LibDev Roadmap Oct 13, 2025
@uniKorqi422
Copy link
Author

uniKorqi422 commented Oct 15, 2025

Sounds good, thank you for letting me know. I am finding my way around here via tutorial and having some integration issues with my GitHub Desktop not being in sync. Happy to adjust based on feedback—should I add a specific test case as well?

@Gui-FernandesBR
Copy link
Member

Sounds good, thank you for letting me know. I am finding my way around here via tutorial and having some integration issues with my GitHub Desktop not being in sync. Happy to adjust based on feedback—should I add a specific test case as well?

you can open the PR irst, then we discuss about tests

@uniKorqi422
Copy link
Author

will do, sorry for the delay, I am running some basics with GitHub Desktop to see what its behavior is with my system to get used to it and see what its good at doing or not. I will get to opening the PR first and then we can discuss about tests. Thanks

@uniKorqi422
Copy link
Author

Ok, Desktop is a big fail at the moment, I am going to run your first simulaiton to get familiar with a few things that I have missed with this awesome program, and will help with a current issue first, there is a lot that I am missing. Discord is fighting with me to collaborate, and was initially looking to collaborate first before diving into this idea. Thanks for your help, I will reach out with whomever I am assisting when I am ready to persue this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

2 participants