-
-
Notifications
You must be signed in to change notification settings - Fork 208
Enh/motor thrustcurve api #870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Marchma0
wants to merge
8
commits into
RocketPy-Team:develop
Choose a base branch
from
IDL-IMTA-Students:enh/motor-thrustcurve-api
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+350
−2
Open
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
05ab711
Add the function to create a motor from the API of thrustcurve and th…
Marchma0 da39fcb
Improve load_from_thrustcurve_api and test_load_from_thrustcurve_api …
Monta120 9fdc704
Clean up load_from_thrustcurve_api and improve test_load_from_thrustc…
Monta120 d123b47
Use warnings.warn() in load_from_thrustcurve_api when motor is found …
Monta120 d6c5dee
Added documentation for the load_from_thrustcurve_api method into the…
Monta120 142eaf8
Changes to conform to lint
Marchma0 8e03cbd
Update GenericMotor documentation and API loader usage
Monta120 29a7aaa
Fix pylint warnings in GenericMotor tests
Monta120 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.