[Mork Borg] Getting Better roll/template is making errors #14355
Description
I've noticed the Getting Better logic is often incorrect. I haven't tested every single number but the pattern of errors seems to be:
-
If the 'ability increase roll' is EQUAL TO or greater than the current ability score, it should default to "Increase the ability +1". But instead it incorrectly defaults to "Decrease the ability -1". It seems like it is treating the evaluation as > when it should be >=. This same logic may spill over to the hp increase, which should also be an increase if the 'hp check roll' is EQUAL TO or greater than current max hp, or a decrease if the roll is less than.
-
If the Getting Better 'ability increase roll' result is a 6 (on a d6) it incorrectly says No Change because the ability modifier cap is +6... but I think it's incorrectly comparing the roll to 6 instead of comparing the ability modifier to 6. A roll of 6 should still result in an increase of the ability modifier (capped at +6). For reasons I can't yet figure out, it seems to judge a roll of 6 correctly when the ability modifier is <0 but fails whenever the modifier is >0.
Rules reference (quoted from the Mork Borg rulebook):
More HP
- Roll 6d10. If the result is equal to or greater than your current maximum hp, increase it by d6.
Ability Changes
- Roll a d6 against every ability. Results equal to or greater than the ability increase it by 1, to a maximum of +6. Results below the ability decrease it by 1.
- Abilities from −3 to +1 are always increased by 1 unless the d6 result is 1. The ability is then reduced by 1, but never below -3.