Skip to content

Commit 355177c

Browse files
committed
Add Aqua tests.
1 parent 2f4146a commit 355177c

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

Project.toml

+2-1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ SparseArrays = "1"
1919
Profile = "9abbd945-dff8-562f-b5e8-e1ebf5ef1b79"
2020
StrideArraysCore = "7792a7ef-975c-4747-a70f-980b88e8d1da"
2121
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
22+
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
2223

2324
[targets]
24-
test = ["Test", "Profile"]
25+
test = ["Test", "Profile", "Aqua"]

Readme.md

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
[![Docs](https://img.shields.io/badge/docs-dev-blue.svg)](https://romeov.github.io/ThreadedDenseSparseMul.jl/dev/)
33
[![Build Status](https://github.com/JuliaCI/BenchmarkTools.jl/workflows/CI/badge.svg)](https://github.com/JuliaCI/BenchmarkTools.jl/actions/workflows/CI.yml?query=branch%3Amaster)
44
[![codecov](https://codecov.io/gh/RomeoV/ProbabilisticParameterEstimators.jl/graph/badge.svg?token=5J82UXPL8I)](https://codecov.io/gh/RomeoV/ThreadedDenseSparseMul.jl)
5+
[![Aqua](https://img.shields.io/badge/Tested_with-Aqua-turquoise)](https://github.com/JuliaTesting/Aqua.jl)
56

67
> Threaded implementation of dense-sparse matrix multiplication, built on top of `Polyester.jl`.
78

test/runtests.jl

+7
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ using ThreadedDenseSparseMul
22
using Test
33
import SparseArrays: mul!, sprand
44
import Profile
5+
import Aqua
56

67
# Helper function to run common test logic
78
function run_common_tests(method!, buf::AbstractMatrix{T}, lhs, rhs, α, β, baseline) where {T <: Number}
@@ -17,6 +18,12 @@ function run_common_tests(method!, buf::AbstractMatrix{T}, lhs, rhs, α, β, bas
1718
end
1819

1920
@testset "ThreadedDenseSparseMul Tests" begin
21+
@testset "Code quality (Aqua.jl)" begin
22+
# gotta split this: see https://github.com/JuliaTesting/Aqua.jl/issues/77
23+
Aqua.test_all(ThreadedDenseSparseMul, ambiguities = false, deps_compat=false)
24+
Aqua.test_ambiguities(ThreadedDenseSparseMul)
25+
Aqua.test_deps_compat(ThreadedDenseSparseMul; check_extras=false)
26+
end
2027
@test ThreadedDenseSparseMul.get_num_threads() == Threads.nthreads()
2128
@testset "Override mul! ?" for override_mul! in [false, true]
2229
override_mul! && ThreadedDenseSparseMul.override_mul!()

0 commit comments

Comments
 (0)