Skip to content

Commit 2103dc3

Browse files
author
Ronny Hansen
committed
Fixed parity signals to correct bits
1 parent b355996 commit 2103dc3

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

Verilog/CPU-BOARD-3202/circuit/MEM_RAM_49.v

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ module MEM_RAM_49 (
5353

5454
// output
5555
wire [17:0] s_dd_17_0_out; // shared output signal depending on bank
56-
wire [17:0] s_dd_17_0_parity; // parity signals (calculation across all banks)
5756
wire s_corr_n;
5857

5958
// BANK0
@@ -136,7 +135,7 @@ module MEM_RAM_49 (
136135
*******************************************************************************/
137136

138137
// or together all 3 banks
139-
assign s_dd_17_0_out = s_dd_17_0_b0_out | s_dd_17_0_b1_out | s_dd_17_0_b2_out | s_dd_17_0_parity;
138+
assign s_dd_17_0_out = s_dd_17_0_b0_out | s_dd_17_0_b1_out | s_dd_17_0_b2_out;
140139

141140
assign s_ras_b0 = ~(s_ras & s_bank0);
142141
assign s_cas_b0 = ~(s_bank0 & s_cas);
@@ -148,11 +147,6 @@ module MEM_RAM_49 (
148147
assign s_ras_b2 = ~(s_ras & s_bank2);
149148
assign s_cas_b2 = ~(s_bank2 & s_cas);
150149

151-
152-
// Parity calculation across all banks
153-
assign s_dd_17_0_parity[8] = q9_b1l | q9_b2l | q9_b0l;
154-
assign s_dd_17_0_parity[17] = q9_b1h | q9_b2h | q9_b0h;
155-
156150
// Calculate CORR ? (in the doc for these RAM chips it seems this pin is not connected..)
157151
assign s_corr_n = (prd_n_b2l & prd_n_b1l & prd_n_b0l & prd_n_b0h & prd_n_b1h & prd_n_b2h);
158152

@@ -174,7 +168,7 @@ module MEM_RAM_49 (
174168
** Here all sub-circuits are defined **
175169
*******************************************************************************/
176170

177-
// **************** BANK 9 ****************
171+
// **************** BANK 0 ****************
178172

179173
SIP1M9 CHIP_15H (
180174
.sysclk(sysclk),
@@ -195,6 +189,8 @@ module MEM_RAM_49 (
195189
.W_n(s_mwrite50_n)
196190
);
197191

192+
assign s_dd_17_0_b0_out[8] = d9_b0l | q9_b0l;
193+
198194
SIP1M9 CHIP_15J (
199195
.sysclk(sysclk),
200196
.sys_rst_n(sys_rst_n),
@@ -214,6 +210,7 @@ module MEM_RAM_49 (
214210
.W_n(s_mwrite50_n)
215211
);
216212

213+
assign s_dd_17_0_b0_out[17] = d9_b0h | q9_b0h;
217214

218215

219216
// **************** BANK 1 ****************
@@ -237,6 +234,8 @@ module MEM_RAM_49 (
237234
.W_n(s_mwrite50_n)
238235
);
239236

237+
assign s_dd_17_0_b1_out[8] = d9_b1l | q9_b1l;
238+
240239
SIP1M9 CHIP_15L (
241240
.sysclk(sysclk),
242241
.sys_rst_n(sys_rst_n),
@@ -256,6 +255,8 @@ module MEM_RAM_49 (
256255
.W_n(s_mwrite50_n)
257256
);
258257

258+
assign s_dd_17_0_b1_out[17] = d9_b1h | q9_b1h;
259+
259260
// **************** BANK 2 ****************
260261

261262
SIP1M9 CHIP_15M (
@@ -277,6 +278,8 @@ module MEM_RAM_49 (
277278
.W_n(s_mwrite50_n)
278279
);
279280

281+
assign s_dd_17_0_b2_out[8] = d9_b2l | q9_b2l;
282+
280283
SIP1M9 CHIP_15N (
281284
.sysclk(sysclk),
282285
.sys_rst_n(sys_rst_n),
@@ -296,6 +299,6 @@ module MEM_RAM_49 (
296299
.W_n(s_mwrite50_n)
297300
);
298301

299-
302+
assign s_dd_17_0_b2_out[17] = d9_b2h | q9_b2h;
300303

301304
endmodule

0 commit comments

Comments
 (0)