Skip to content

Commit 022d606

Browse files
committed
fix: add missing translation keys for edit subtask instructions
- Add editInstructions and editPlaceholder keys to chat.json subtasks section - Add error_editing_subtask key to common.json errors.message section - Fix translation key references in ChatRow.tsx to use correct paths - Rebased on main to pick up latest changes
1 parent aa35136 commit 022d606

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

src/i18n/locales/en/common.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,8 @@
100100
"cannot_delete_invalid_timestamp": "Cannot delete message: invalid timestamp",
101101
"message_not_found": "Message with timestamp {{messageTs}} not found",
102102
"error_deleting_message": "Error deleting message: {{error}}",
103-
"error_editing_message": "Error editing message: {{error}}"
103+
"error_editing_message": "Error editing message: {{error}}",
104+
"error_editing_subtask": "Error editing subtask: {{error}}"
104105
},
105106
"gemini": {
106107
"generate_stream": "Gemini generate context stream error: {{error}}",

webview-ui/src/components/chat/ChatRow.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -867,7 +867,7 @@ export const ChatRowContent = ({
867867
e.stopPropagation()
868868
handleEditSubtaskClick()
869869
}}
870-
title={t("chat:editSubtaskInstructions")}
870+
title={t("chat:subtasks.editInstructions")}
871871
style={{
872872
padding: "2px 4px",
873873
borderRadius: "3px",
@@ -892,19 +892,19 @@ export const ChatRowContent = ({
892892
fontFamily: "var(--vscode-editor-font-family)",
893893
fontSize: "var(--vscode-editor-font-size)",
894894
}}
895-
placeholder={t("chat:editSubtaskInstructions.placeholder")}
895+
placeholder={t("chat:subtasks.editPlaceholder")}
896896
autoFocus
897897
/>
898898
<div className="flex gap-2 justify-end">
899899
<button
900900
onClick={handleCancelEditSubtask}
901901
className="px-3 py-1 rounded bg-vscode-button-secondaryBackground text-vscode-button-secondaryForeground hover:bg-vscode-button-secondaryHoverBackground">
902-
{t("chat:cancel")}
902+
{t("chat:cancel.title")}
903903
</button>
904904
<button
905905
onClick={handleSaveEditSubtask}
906906
className="px-3 py-1 rounded bg-vscode-button-background text-vscode-button-foreground hover:bg-vscode-button-hoverBackground">
907-
{t("chat:save")}
907+
{t("chat:save.title")}
908908
</button>
909909
</div>
910910
</div>

webview-ui/src/i18n/locales/en/chat.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,9 @@
278278
"completionContent": "Subtask Completed",
279279
"resultContent": "Subtask Results",
280280
"defaultResult": "Please continue to the next task.",
281-
"completionInstructions": "Subtask completed! You can review the results and suggest any corrections or next steps. If everything looks good, confirm to return the result to the parent task."
281+
"completionInstructions": "Subtask completed! You can review the results and suggest any corrections or next steps. If everything looks good, confirm to return the result to the parent task.",
282+
"editInstructions": "Edit subtask instructions",
283+
"editPlaceholder": "Edit subtask instructions..."
282284
},
283285
"questions": {
284286
"hasQuestion": "Roo has a question"

0 commit comments

Comments
 (0)