[ENHANCEMENT] The enter button should work as approval, not denial.

[omagoduck]

Problem (one or two sentences)

When Roo needs an action approval, clicking 'Enter' dismisses that action. But the normal behaviour should be approving that action.

Context (who is affected and when)

When Roo needs an action approval, clicking 'Enter' dismisses that action. But the normal behaviour should be approving that action. I accidentally made such mistakes many times.

I know it will break some users' muscle memory, but hey, generally, it will improve the user experience so much. Just make it happen and give a huge announcement about this behaviour.

Desired behavior (conceptual, not technical)

Described above ⬆️

Constraints / preferences (optional)

No response

Request checklist

• I've searched existing Issues and Discussions for duplicates
• This describes a specific problem with clear context and impact

Roo Code Task Links (optional)

No response

Acceptance criteria (optional)

No response

Proposed approach (optional)

Make that clicking Enter approves the action.

Trade-offs / risks (optional)

It may break some users' muscle memory, but it will improve the overall experience of Roo.

[roomote]

I've analyzed this issue and here's my proposed implementation plan:

Problem Analysis

When Roo shows action approval buttons (e.g., "Approve"/"Reject" for tool usage), pressing Enter in the text area does nothing if the text is empty. The acceptInput command already has the correct behavior (it triggers the primary button/approval when buttons are visible), but this isn't connected to the Enter key in the text area.

Proposed Solution

Modify the Enter key handling in ChatTextArea.tsx to delegate to the acceptInput mechanism when action approval buttons are visible. This way:

1. When action buttons are visible (like Approve/Reject), pressing Enter will trigger the primary action (Approve/Save/Run Command)
2. When no action buttons are visible, Enter continues to send messages as normal
3. Users who want to provide feedback text with their approval can still type and press Enter, which will approve with the feedback included

Implementation Details

1. Modify ChatTextArea.tsx: Add a prop or callback that checks if action buttons are enabled and delegates the Enter key press appropriately

2. Update ChatView.tsx: Pass the necessary state/callback to ChatTextArea so it knows when to trigger the primary button action instead of just sending a message

3. Preserve existing behavior: When the user has typed text, Enter will still send that text (as feedback to the action)

Behavior Change Summary

Current Behavior	New Behavior
Enter with empty input + buttons visible = nothing happens	Enter with empty input + buttons visible = triggers primary button (Approve)
Enter with text + buttons visible = sends text as feedback	Enter with text + buttons visible = sends text as feedback (unchanged)
Enter when no task = does nothing	Enter when no task = does nothing (unchanged)

This approach aligns with common UX patterns where Enter confirms/accepts the current action, while the text area still allows users to provide optional feedback before approving.

Please mention @roomote in a comment saying that you approve this plan, and I'll proceed with the implementation.

[omagoduck]

@roomote Right now the behaviour is if there is nothing ig enter doesn't do anything. if there is text or content, enter rejects the action and send the message as well. But wanted it when there is no content in input enter just approve, and if there is content in input then enter should approve and send.

[roomote]

Thanks for the clarification! I understand the expected behavior now:

1. Empty input + action buttons visible: Enter should approve the action
2. Input with text + action buttons visible: Enter should approve AND send the text (not reject)

This is different from my initial analysis where I thought the current behavior was "nothing happens" with empty input. I will update my implementation to ensure Enter always approves (not rejects) regardless of whether there is text.

Will proceed with the implementation and open a PR shortly.

[omagoduck]

@roomote not only text. there may be other content

[roomote]

Thanks for the clarification @omagoduck! I understand that the input can contain not only text but also other content types like images or file attachments. I will explore how the chat input handles different content types and ensure the Enter key behavior (approve + send content) works correctly for all content types, not just text. I'll proceed with the investigation and implementation.

[roomote]

Opened a draft PR with my attempt at addressing this: #10356

The implementation adds an onAccept callback to the ChatTextArea component that triggers the primary button click (approve) when action buttons are visible. This way, pressing Enter now:

• Empty input: Approves the action (same as clicking the primary button)
• With text: Approves AND sends the text as feedback

All existing tests pass. Feedback welcome!