[BUG]

[wasleen]

Problem (one or two sentences)

Error Stack:
TypeError: Cannot read properties of undefined (reading 'trim')
at inputValue.trim (../../../../webview-ui/src/components/chat/ChatTextArea.tsx:262:21)
at ti (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:172:118)
at useMemo (../../../../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js:26:47)
at inputValue.trim (../../../../webview-ui/src/components/chat/ChatTextArea.tsx:261:26)
at Nh (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:160:136)
at Yi (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:192:56)
at f,b.memoizedState=f,b.flags&256){e=Ji(Error(p(423)),b);b=lj (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:293:274)
at tj (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:279:388)
at tj (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:279:319)
at tj (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:279:179)
Component Stack:

at https://file+.vscode-resource.vscode-cdn.net/c%3A/Users/jamsh/.cursor/extensions/rooveterinaryinc.roo-cline-3.53.0-universal/webview-ui/build/assets/index.js:2966:207656
at div

at nco (../../../../webview-ui/src/components/chat/ChatView.tsx:69:3)
at bvo (../../../../webview-ui/src/App.tsx:69:5)
at d (../../../../node_modules/.pnpm/@radix-ui+react-context@1.1.2_@types+react@18.3.23_react@18.3.1/node_modules/@radix-ui/react-context/dist/index.mjs:27:14)
at kLt (../../../../node_modules/.pnpm/@radix-ui+react-tooltip@1.2.6_@types+react-dom@18.3.7_@types+react@18.3.23__@types+reac_99504aa956c623e0884a4e3cb215669a/node_modules/@radix-ui/react-tooltip/dist/index.mjs:29:4)
at R3 (../../../../webview-ui/src/components/ui/tooltip.tsx:8:47704)
at mFt (../../../../node_modules/.pnpm/@TanStack+react-query@5.76.1_react@18.3.1/node_modules/@tanstack/react-query/build/modern/QueryClientProvider.js:20:2)
at tHt (../../../../webview-ui/src/i18n/TranslationContext.tsx:16:70)
at YVt (../../../../webview-ui/src/context/ExtensionStateContext.tsx:192:86)
at lvo (../../../../webview-ui/src/components/ErrorBoundary.tsx:18:2)
at i (../../../../node_modules/.pnpm/react-i18next@15.5.1_i18next@25.2.1_typescript@5.8.3__react-dom@18.3.1_react@18.3.1__react@18.3.1_typescript@5.8.3/node_modules/react-i18next/dist/es/withTranslation.js:6:4)
at kvo (../../../../webview-ui/src/App.tsx:319:25)

Context (who is affected and when)

Copy and paste the following error message to include it as part of your submission:

Error Stack:
TypeError: Cannot read properties of undefined (reading 'trim')
at inputValue.trim (../../../../webview-ui/src/components/chat/ChatTextArea.tsx:262:21)
at ti (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:172:118)
at useMemo (../../../../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js:26:47)
at inputValue.trim (../../../../webview-ui/src/components/chat/ChatTextArea.tsx:261:26)
at Nh (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:160:136)
at Yi (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:192:56)
at f,b.memoizedState=f,b.flags&256){e=Ji(Error(p(423)),b);b=lj (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:293:274)
at tj (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:279:388)
at tj (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:279:319)
at tj (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:279:179)
Component Stack:

at https://file+.vscode-resource.vscode-cdn.net/c%3A/Users/jamsh/.cursor/extensions/rooveterinaryinc.roo-cline-3.53.0-universal/webview-ui/build/assets/index.js:2966:207656
at div

at nco (../../../../webview-ui/src/components/chat/ChatView.tsx:69:3)
at bvo (../../../../webview-ui/src/App.tsx:69:5)
at d (../../../../node_modules/.pnpm/@radix-ui+react-context@1.1.2_@types+react@18.3.23_react@18.3.1/node_modules/@radix-ui/react-context/dist/index.mjs:27:14)
at kLt (../../../../node_modules/.pnpm/@radix-ui+react-tooltip@1.2.6_@types+react-dom@18.3.7_@types+react@18.3.23__@types+reac_99504aa956c623e0884a4e3cb215669a/node_modules/@radix-ui/react-tooltip/dist/index.mjs:29:4)
at R3 (../../../../webview-ui/src/components/ui/tooltip.tsx:8:47704)
at mFt (../../../../node_modules/.pnpm/@TanStack+react-query@5.76.1_react@18.3.1/node_modules/@tanstack/react-query/build/modern/QueryClientProvider.js:20:2)
at tHt (../../../../webview-ui/src/i18n/TranslationContext.tsx:16:70)
at YVt (../../../../webview-ui/src/context/ExtensionStateContext.tsx:192:86)
at lvo (../../../../webview-ui/src/components/ErrorBoundary.tsx:18:2)
at i (../../../../node_modules/.pnpm/react-i18next@15.5.1_i18next@25.2.1_typescript@5.8.3__react-dom@18.3.1_react@18.3.1__react@18.3.1_typescript@5.8.3/node_modules/react-i18next/dist/es/withTranslation.js:6:4)
at kvo (../../../../webview-ui/src/App.tsx:319:25)

Reproduction steps

Windows OS, Cursor,

Expected result

error

Actual result

Error Stack:

Variations tried (optional)

No response

App Version

v3

API Provider (optional)

DeepSeek

Model Used (optional)

No response

Roo Code Task Links (optional)

No response

Relevant logs or errors (optional)

[roomote-v0]

I've analyzed this issue and here's my proposed implementation plan:

Root Cause:
The crash at ChatTextArea.tsx:262 happens because inputValue.trim() is called when inputValue is undefined. Although inputValue is typed as string and initialized via useState("") in ChatView.tsx, it can become undefined at runtime -- most likely through the document.execCommand("insertText") path in the enhanced prompt handler (line 149), which modifies the textarea DOM directly and can desync from React state, or through edge cases with inputValueRef.current being passed to setInputValue.

Proposed Fix:
Add defensive fallbacks (inputValue ?? "") before every .trim() call on inputValue across both files:

1. ChatTextArea.tsx line 248 -- handleEnhancePrompt: change inputValue.trim() to (inputValue ?? "").trim()
2. ChatTextArea.tsx line 262 -- hasInputContent useMemo: change inputValue.trim() to (inputValue ?? "").trim()
3. ChatView.tsx line 206 -- isFollowUpAutoApprovalPaused: already has a guard (inputValue &&), no change needed
4. ChatView.tsx line 713 -- handleEnqueueCurrentMessage: change inputValue.trim() to (inputValue ?? "").trim()
5. ChatView.tsx line 1539 -- acceptInput: change inputValue.trim() to (inputValue ?? "").trim()
6. ChatView.tsx line 1544 -- queue message: change inputValue.trim() to (inputValue ?? "").trim()

This is a minimal, safe fix that prevents the TypeError without altering any behavior when inputValue is a valid string. Tests will be added/updated to cover the undefined edge case.

Please mention @roomote in a comment saying that you approve this plan, and I'll proceed with the implementation.