feat: add next step suggestions and XML utilities #1084
+1,160
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhvw8
requested review from
stea9499,
ColemanRoo,
mrubens and
cte
as code owners
|
samhvw8
commented
Feb 20, 2025
src/core/Cline.ts
Outdated
| parsedSuggest = parseXml(next_step, ["next_step.suggest"]) as { | ||
| suggest: Suggest[] | Suggest | ||
| } | ||
| console.log("next_step", next_step) |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| <span | ||
| className="codicon codicon-question" // TODO: change icon | ||
| style={{ color: normalColor, marginBottom: "-1.5px" }}></span>, | ||
| <span style={{ color: normalColor, fontWeight: "bold" }}>Roo has suggest prompt:</span>, |
There was a problem hiding this comment.
Typo: The text 'Roo has suggest prompt:' seems off. Consider updating it to a more grammatically correct phrase such as 'Roo has a suggestion prompt:' or 'Roo suggests a prompt:' to improve clarity.
Suggested change
| <span style={{ color: normalColor, fontWeight: "bold" }}>Roo has suggest prompt:</span>, | |
| <span style={{ color: normalColor, fontWeight: "bold" }}>Roo has a suggestion prompt:</span>, |
|
|
dosubot
bot
added
the
size:L
samhvw8
force-pushed
the
feat/next-step-attempt-complete
branch
2 times, most recently
from
ec14df6 to
7716989
Compare
- Add NextStepSuggest component for displaying suggested next steps - Add XML utilities for improved XML parsing - Update ChatView and ChatRow to handle next step suggestions - Add fast-xml-parser dependency - Update package dependencies update snapshoot feat(ui): enhance next step suggestions UX and documentation - Improve next step UI with collapsible view and show more/less toggle - Add type validation and error handling for suggestion parsing - Update documentation with clearer formatting guidelines and examples - Enhance button styling and accessibility for better user interaction update snapshot refactor: move next step suggestions into chat row for better UX feat: enhance next step suggestions with mode selection - Make next_step parameter required in attempt_completion tool - Update suggestion format to include task and mode fields - Enhance UI to display mode alongside task description - Update parsing logic to handle new suggestion format - Improve error handling for missing or invalid suggestions refactor(NextStepSuggest): improve component with shadcn UI and better styling - Replace native buttons with shadcn Button component - Increase button dimensions for better readability - Add proper text wrapping and overflow handling - Style mode text as VSCode badge - Improve hover and active states - Maintain VSCode theming integration - Show 3 suggestions in non-expanded mode
- Remove next_step_suggest from experiments - Make next step suggestions a required parameter in attempt_completion - Update documentation to reflect next step suggestions as core functionality - Remove experimental conditionals from objective and rules sections
samhvw8
force-pushed
the
feat/next-step-attempt-complete
branch
from
7716989 to
e58f27f
Compare
…e isolation - Add expand/collapse functionality to show more/less suggestions - Implement instance-specific state management via instanceId prop - Add Show More/Less button with suggestion count - Improve accessibility with ARIA labels - Add Lucide icons for visual indicators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature suggest for user next step and make user use new_task tool more easy, can help user control task (and cost indirectly way) more efficient
Type of change
How Has This Been Tested?
Checklist:
Additional context
Related Issues
Reviewers
Important
This PR adds a feature for suggesting next steps using a new component and XML utilities, updating several components and files to integrate these features.
NextStepSuggestcomponent inNextStepSuggest.tsxfor displaying suggested next steps.ChatView.tsxandChatRow.tsxto handlenext_step_suggestmessages.fast-xml-parserdependency inpackage.jsonfor XML parsing.parseXml()function inxml.tsfor XML parsing with error handling.getObjectiveSection()inobjective.tsandgetRulesSection()inrules.tsto include next step suggestions.getAttemptCompletionDescription()inattempt-completion.tsto describenext_stepparameter.ToolArgsintypes.tsto includeexperimentsparameter.NEXT_STEP_SUGGESTtoEXPERIMENT_IDSinexperiments.ts.next_step_suggesttoClineAskandClineSayinExtensionMessage.ts.This description was created by
for 38616db. It will automatically update as commits are pushed.