Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI fix for copy command #884 #1101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

emshvac
Copy link

@emshvac emshvac commented Feb 21, 2025

Moving the "Copied to Clipboard" message above the content for better visibility Increasing the feedback duration to 2 seconds to make it more noticeable Maintaining the subtle hover effect for discoverability Keeping the brief flash effect when copying

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Manual testing

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

We may also want to implement this in other areas such as execute command and other areas that a user may want to copy. It is very unobtrusive.

Recording.2025-02-20.193621.mp4

Related Issues

Fixes: #884

Reviewers


Important

Improves UI feedback for copy command in ChatRow.tsx by repositioning the message, extending duration, and maintaining hover effects.

  • UI Changes in ChatRow.tsx:
    • Move "Copied to Clipboard" message above content for better visibility.
    • Increase feedback duration to 2 seconds for better noticeability.
    • Maintain subtle hover effect for discoverability.
    • Keep brief flash effect when copying.

This description was created by Ellipsis for 98ee80c. It will automatically update as commits are pushed.

Moving the "Copied to Clipboard" message above the content for better visibility
Increasing the feedback duration to 2 seconds to make it more noticeable
Maintaining the subtle hover effect for discoverability
Keeping the brief flash effect when copying
Copy link

changeset-bot bot commented Feb 21, 2025

⚠️ No Changeset found

Latest commit: 98ee80c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@emshvac emshvac marked this pull request as ready for review February 21, 2025 01:52
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Feb 21, 2025
Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think there's enough affordance that clicking on the text copies it? I agree with the original issue that the copy icon could get in the way, but I think it did make it more clear that the text was copyable. Is there some middle ground?

@emshvac
Copy link
Author

emshvac commented Feb 21, 2025

@mrubens I don't know if you noticed the tool tip that was added when you hover. It went away really quick in the video due to my click.

There is no room in the chat history for the copy icon.

If you feel like more is needed I propose the follow solutions:

  1. Making the highlight of the text more visible
    or
  2. When hover over message shift it down and show a copy button (i think this is messy)
    or
  3. Make this an item that when the user first opens the software for the first time it is part of the walk through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI fix for copy command
2 participants