Add shell override configuration #1121
Open
+56
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes macOS zsh prompt parsing issue (#237)
Description
This PR addresses an issue with terminal prompt parsing on macOS when using zsh. The fix involves an approach to set the shell for Roo Code to bash for terminal integration, which avoids the complexity of zsh prompt handling and not forcing users to switch to bash in VS Code for the fix.
Type of change
How Has This Been Tested?
The fix has been tested by:
Checklist:
Additional context
This change specifically targets macOS systems where zsh is the default shell (macOS Catalina and newer). It should work well on other platforms yet not tested. The configuration update might need documentations.
Related Issues
Fixes #237
Important
Add configuration to override default shell paths for macOS, Linux, and Windows, addressing macOS zsh prompt parsing issue.
roo-cline.shell
configuration inpackage.json
to override shell paths for macOS, Linux, and Windows.TerminalRegistry.ts
to usegetAutomationShellConfig()
for shell path and args.getShellConfigKey()
to determine platform-specific shell configuration keys.TerminalProfile
inshell.ts
to includeargs
.This description was created by
for 06f1e81. It will automatically update as commits are pushed.