Commit 1f6cb12
committed
Filter rcedit input to Windows PE binaries only
The Windows packaging step runs rcedit.exe over every *.node file under
the bundled node_modules to stamp PE metadata. rcedit only understands
Windows PE format and crashes on Mach-O / ELF cross-platform prebuilds
shipped by copilot transitive deps (claude-agent-sdk audio-capture,
foundry-local-sdk, @picovoice/pvrecorder-node, @github/copilot/sdk/
prebuilds, etc.).
Check the first two magic bytes (MZ = 0x4D 0x5A) before invoking rcedit
and skip files that aren't Windows PE. Kills the entire class of bug
without per-package .moduleignore maintenance. Same fix applied in the
REH (server) build path.
Removes the three reactive .moduleignore entries added over the last
24 hours; they're now redundant.1 parent 6cbe7ff commit 1f6cb12
3 files changed
Lines changed: 33 additions & 17 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
243 | 243 | | |
244 | 244 | | |
245 | 245 | | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | | - | |
250 | | - | |
251 | | - | |
252 | | - | |
253 | | - | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
260 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
443 | 443 | | |
444 | 444 | | |
445 | 445 | | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
446 | 461 | | |
447 | | - | |
| 462 | + | |
448 | 463 | | |
449 | 464 | | |
450 | 465 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
556 | 556 | | |
557 | 557 | | |
558 | 558 | | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
559 | 575 | | |
560 | | - | |
| 576 | + | |
561 | 577 | | |
562 | 578 | | |
563 | 579 | | |
| |||
0 commit comments