Merge pull request #301 from YuanYuYuan/fix/uint8-and-byte

Carter12s · web-flow · commit 5d98d91fb5f4 · 2026-01-13T12:03:53.000-07:00
Enable serde_bytes for both the vector of uint8 and byte
diff --git a/roslibrust_codegen/src/gen.rs b/roslibrust_codegen/src/gen.rs
@@ -280,7 +280,7 @@ fn generate_field_definition(
     // For larger arrays, we need special handling via BigArray.
     const MAX_FIXED_ARRAY_LEN: usize = 32;
 
-    let is_uint8_field = field.field_type.field_type == "uint8";
+    let is_uint8_field = matches!(field.field_type.field_type.as_str(), "uint8" | "byte");
 
     let serde_line = match &field.field_type.array_info {
         // Dynamic-length arrays (Vec<T>)
diff --git a/roslibrust_test/src/ros1.rs b/roslibrust_test/src/ros1.rs
@@ -10973,6 +10973,7 @@ pub mod std_msgs {
     #[serde(crate = "::roslibrust::codegen::serde")]
     pub struct ByteMultiArray {
         pub r#layout: self::MultiArrayLayout,
+        #[serde(with = "::roslibrust::codegen::serde_rosmsg_bytes")]
         pub r#data: ::std::vec::Vec<u8>,
     }
     impl ::roslibrust::RosMessageType for ByteMultiArray {
diff --git a/roslibrust_test/src/ros2.rs b/roslibrust_test/src/ros2.rs
@@ -9045,6 +9045,7 @@ byte data"####;
     #[serde(crate = "::roslibrust::codegen::serde")]
     pub struct ByteMultiArray {
         pub r#layout: self::MultiArrayLayout,
+        #[serde(with = "::roslibrust::codegen::serde_rosmsg_bytes")]
         pub r#data: ::std::vec::Vec<u8>,
     }
     impl ::roslibrust::RosMessageType for ByteMultiArray {

Original file line number	Diff line number	Diff line change
`@@ -10973,6 +10973,7 @@ pub mod std_msgs {`
`10973`	`10973`	`#[serde(crate = "::roslibrust::codegen::serde")]`
`10974`	`10974`	`pub struct ByteMultiArray {`
`10975`	`10975`	`pub r#layout: self::MultiArrayLayout,`
	`10976`	`+ #[serde(with = "::roslibrust::codegen::serde_rosmsg_bytes")]`
`10976`	`10977`	`pub r#data: ::std::vec::Vec<u8>,`
`10977`	`10978`	`}`
`10978`	`10979`	`impl ::roslibrust::RosMessageType for ByteMultiArray {`
Original file line number	Diff line number	Diff line change
`@@ -9045,6 +9045,7 @@ byte data"####;`
`9045`	`9045`	`#[serde(crate = "::roslibrust::codegen::serde")]`
`9046`	`9046`	`pub struct ByteMultiArray {`
`9047`	`9047`	`pub r#layout: self::MultiArrayLayout,`
	`9048`	`+ #[serde(with = "::roslibrust::codegen::serde_rosmsg_bytes")]`
`9048`	`9049`	`pub r#data: ::std::vec::Vec<u8>,`
`9049`	`9050`	`}`
`9050`	`9051`	`impl ::roslibrust::RosMessageType for ByteMultiArray {`