Config Option For Money Serialization

[Numie]

Currently, the default serialization of a Money object results in an object with keys of cents and currency_iso:

m = Money.new(1000, 'USD')
m.to_json

=> "{\"cents\":1000, \"currency_iso\":\"USD\"}"

This is implemented by defining to_hash on Money here:

money-rails/lib/money-rails/money.rb

Line 27 in 79df005

{ cents: cents, currency_iso: currency.iso_code.to_s }

The serialization is awkward for currencies that don't include cents, for example JPY:

m = Money.new(1000, 'JPY')
m.to_json

=> "{\"cents\":1000, \"currency_iso\":\"JPY\"}"

Is there any openness to adding a config option that would allow for customizing this behavior? E.g. config.amount_serialization_key = :amount could result in:

m = Money.new(1000, 'JPY')
m.to_json

=> "{\"amount\":1000, \"currency_iso\":\"JPY\"}"

[sunny]

Although a bit awkward, cents is the name for Money’s smallest denomination. I don’t think I’d be in favor of adding a configuration just for this as there could be plenty of different ways people would like to serialize an amount that should probably be done within an app's serializer/deserializers.

[Numie]

Point taken that an app can simply use its own serializers, and is what we will do barring a config option, but it will result in a bunch of extra lines of code for apps with a large number of money attributes across many different models.

Although cents is internally Money's smallest denomination, shouldn't the default serialization at least be configurable to work with other currencies that don't use cents?

Really appreciate your consideration.

[sunny]

It would make sense to be able to choose your own serializer in the configuration to avoid having to build many serializers. However the issue with a configuration is that you might rely on a gem that expects the default serializers. If you want to change the name of Money's smallest denomination in the to_json method, then perhaps using Ruby refinements would be the way around this?