Lint: RSpec cops (#1181)

Author: sunny

.rubocop.yml

@@ -39,6 +39,14 @@ Lint/EmptyClass:
   # Allow defining empty classes, since it can be used as a base class.
   Enabled: false
 
+# RSpec
+
+RSpec/DescribedClass:
+  Exclude:
+    # Prefer Money.new(…) to described_class.new(…)
+    - 'spec/money_spec.rb'
+    - 'spec/money/formatting_spec.rb'
+
 # Style
 
 Style/ClassAndModuleChildren:

.rubocop_todo.yml

@@ -27,7 +27,7 @@ def setup
       end
 
       bank = MyBank.new
-      expect(bank.setup_called).to eq true
+      expect(bank.setup_called).to be true
     end
   end
 
@@ -39,19 +39,19 @@ def setup
 
   describe "#same_currency?" do
     it "accepts str/str" do
-      expect { subject.send(:same_currency?, 'USD', 'EUR') }.to_not raise_error
+      expect { subject.send(:same_currency?, 'USD', 'EUR') }.not_to raise_error
     end
 
     it "accepts currency/str" do
-      expect { subject.send(:same_currency?, Money::Currency.wrap('USD'), 'EUR') }.to_not raise_error
+      expect { subject.send(:same_currency?, Money::Currency.wrap('USD'), 'EUR') }.not_to raise_error
     end
 
     it "accepts str/currency" do
-      expect { subject.send(:same_currency?, 'USD', Money::Currency.wrap('EUR')) }.to_not raise_error
+      expect { subject.send(:same_currency?, 'USD', Money::Currency.wrap('EUR')) }.not_to raise_error
     end
 
     it "accepts currency/currency" do
-      expect { subject.send(:same_currency?, Money::Currency.wrap('USD'), Money::Currency.wrap('EUR')) }.to_not raise_error
+      expect { subject.send(:same_currency?, Money::Currency.wrap('USD'), Money::Currency.wrap('EUR')) }.not_to raise_error
     end
 
     it "returns true when currencies match" do

spec/bank/base_spec.rb

@@ -34,11 +34,11 @@
 
       describe "#exchange_with" do
         it "accepts str" do
-          expect { bank.exchange_with(Money.new(100, 'USD'), 'EUR') }.to_not raise_error
+          expect { bank.exchange_with(Money.new(100, 'USD'), 'EUR') }.not_to raise_error
         end
 
         it "accepts currency" do
-          expect { bank.exchange_with(Money.new(100, 'USD'), Money::Currency.wrap('EUR')) }.to_not raise_error
+          expect { bank.exchange_with(Money.new(100, 'USD'), Money::Currency.wrap('EUR')) }.not_to raise_error
         end
 
         it "exchanges one currency to another" do
@@ -109,7 +109,7 @@
   describe "#add_rate" do
     it 'delegates to store#add_rate' do
       expect(subject.store).to receive(:add_rate).with('USD', 'EUR', 1.25).and_return 1.25
-      expect(subject.add_rate('USD', 'EUR', 1.25)).to eql 1.25
+      expect(subject.add_rate('USD', 'EUR', 1.25)).to be 1.25
     end
 
     it "adds rates with correct ISO codes" do
@@ -129,7 +129,7 @@
   describe "#set_rate" do
     it 'delegates to store#add_rate' do
       expect(subject.store).to receive(:add_rate).with('USD', 'EUR', 1.25).and_return 1.25
-      expect(subject.set_rate('USD', 'EUR', 1.25)).to eql 1.25
+      expect(subject.set_rate('USD', 'EUR', 1.25)).to be 1.25
     end
 
     it "sets a rate" do
@@ -159,28 +159,28 @@
   end
 
   describe "#export_rates" do
-    before :each do
+    before do
       subject.set_rate('USD', 'EUR', 1.25)
       subject.set_rate('USD', 'JPY', 2.55)
 
       @rates = { "USD_TO_EUR" => 1.25, "USD_TO_JPY" => 2.55 }
     end
 
     context "with format == :json" do
-      it "should return rates formatted as json" do
+      it "returns rates formatted as json" do
         json = subject.export_rates(:json)
         expect(JSON.load(json)).to eq @rates
       end
     end
 
     context "with format == :ruby" do
-      it "should return rates formatted as ruby objects" do
+      it "returns rates formatted as ruby objects" do
         expect(Marshal.load(subject.export_rates(:ruby))).to eq @rates
       end
     end
 
     context "with format == :yaml" do
-      it "should return rates formatted as yaml" do
+      it "returns rates formatted as yaml" do
         yaml = subject.export_rates(:yaml)
         expect(YAML.load(yaml)).to eq @rates
       end
@@ -263,7 +263,7 @@
 
   describe "#marshal_dump" do
     it "does not raise an error" do
-      expect { Marshal.dump(subject) }.to_not raise_error
+      expect { Marshal.dump(subject) }.not_to raise_error
     end
 
     it "works with Marshal.load" do

spec/bank/variable_exchange_spec.rb

@@ -2,7 +2,7 @@
 
 RSpec.describe Money::Currency::Heuristics do
   describe "#analyze_string" do
-    it "it raises deprecation error" do
+    it "raises deprecation error" do
       expect { Money::Currency.analyze('123') }.to raise_error(StandardError, 'Heuristics deprecated, add `gem "money-heuristics"` to Gemfile')
     end
   end

spec/currency/heuristics_spec.rb

@@ -134,14 +134,17 @@ def to_s
     it "returns an array of currencies" do
       expect(described_class.all).to include described_class.new(:usd)
     end
+
     it "includes registered currencies" do
       register_foo
       expect(described_class.all).to include described_class.new(:foo)
       unregister_foo
     end
+
     it 'is sorted by priority' do
       expect(described_class.all.first.priority).to eq 1
     end
+
     it "raises a MissingAttributeError if any currency has no priority" do
       register_foo(skip: :priority)
 
@@ -286,7 +289,7 @@ def to_s
     end
 
     it 'returns new object for the different :key' do
-      expect(described_class.new("USD")).to_not be(described_class.new("EUR"))
+      expect(described_class.new("USD")).not_to be(described_class.new("EUR"))
     end
 
     it 'is thread safe' do

spec/currency_spec.rb

@@ -13,7 +13,7 @@
     end
 
     it 'returns format based as defined in currency' do
-      expect(subject.lookup(:format, currency)).to eq(nil)
+      expect(subject.lookup(:format, currency)).to be_nil
     end
   end
 end

spec/locale_backend/currency_spec.rb

@@ -10,12 +10,12 @@
   end
 
   describe '#lookup' do
+    subject { described_class.new }
+
     after do
       I18n.locale = :en
     end
 
-    subject { described_class.new }
-
     context 'with number.currency.format defined' do
       before do
         I18n.locale = :de
@@ -58,19 +58,19 @@
 
     context 'with no translation defined' do
       it 'returns thousands_separator based on the current locale' do
-        expect(subject.lookup(:thousands_separator, nil)).to eq(nil)
+        expect(subject.lookup(:thousands_separator, nil)).to be_nil
       end
 
       it 'returns decimal_mark based on the current locale' do
-        expect(subject.lookup(:decimal_mark, nil)).to eq(nil)
+        expect(subject.lookup(:decimal_mark, nil)).to be_nil
       end
 
       it 'returns symbol based on the current locale' do
-        expect(subject.lookup(:symbol, nil)).to eq(nil)
+        expect(subject.lookup(:symbol, nil)).to be_nil
       end
 
       it 'returns format based on the current locale' do
-        expect(subject.lookup(:format, nil)).to eq(nil)
+        expect(subject.lookup(:format, nil)).to be_nil
       end
     end
   end