Lint: Fix Naming/BlockForwarding & Style/ArgumentsForwarding

See also #1134

Author: sunny

.rubocop_todo.yml

@@ -102,7 +102,7 @@ def setup
       # @yieldreturn [Integer]
       #
       # @return [Money]
-      def exchange_with(from, to_currency, &block)
+      def exchange_with(from, to_currency, &)
         raise NotImplementedError, "#exchange_with must be implemented"
       end
 

lib/money/bank/base.rb

@@ -18,7 +18,7 @@ class SingleCurrency < Base
 
       # Raises a DifferentCurrencyError to remove possibility of accidentally
       # exchanging currencies
-      def exchange_with(from, to_currency, &block)
+      def exchange_with(from, to_currency, &)
         raise DifferentCurrencyError, "No exchanging of currencies allowed: #{from} #{from.currency} to #{to_currency}"
       end
     end

lib/money/bank/single_currency.rb

@@ -58,9 +58,9 @@ class VariableExchange < Base
       # @param [RateStore] st An exchange rate store, used to persist exchange rate pairs.
       # @yield [n] Optional block to use when rounding after exchanging one
       #  currency for another. See +Money::bank::base+
-      def initialize(st = Money::RatesStore::Memory.new, &block)
+      def initialize(st = Money::RatesStore::Memory.new, &)
         @store = st
-        super(&block)
+        super(&)
       end
 
       def store
@@ -108,15 +108,15 @@ def marshal_load(arr)
       #
       #   # Exchange 100 CAD to USD:
       #   bank.exchange_with(c2, "USD") #=> #<Money fractional:8031 currency:USD>
-      def exchange_with(from, to_currency, &block)
+      def exchange_with(from, to_currency, &)
         to_currency = Currency.wrap(to_currency)
         if from.currency == to_currency
           from
         else
           if rate = get_rate(from.currency, to_currency)
             fractional = calculate_fractional(from, to_currency)
             from.dup_with(
-              fractional: exchange(fractional, rate, &block),
+              fractional: exchange(fractional, rate, &),
               currency: to_currency,
               bank: self,
             )
@@ -133,7 +133,7 @@ def calculate_fractional(from, to_currency)
         )
       end
 
-      def exchange(fractional, rate, &block)
+      def exchange(fractional, rate, &)
         ex = fractional * BigDecimal(rate.to_s)
         if block_given?
           yield ex

lib/money/bank/variable_exchange.rb

@@ -509,12 +509,12 @@ def to_money(given_currency = nil)
   #   Money.new(2000, "USD").exchange_to("EUR")
   #   Money.new(2000, "USD").exchange_to("EUR") {|x| x.round}
   #   Money.new(2000, "USD").exchange_to(Currency.new("EUR"))
-  def exchange_to(other_currency, &rounding_method)
+  def exchange_to(other_currency, &)
     other_currency = Currency.wrap(other_currency)
     if self.currency == other_currency
       self
     else
-      @bank.exchange_with(self, other_currency, &rounding_method)
+      @bank.exchange_with(self, other_currency, &)
     end
   end
 

lib/money/money.rb

@@ -72,7 +72,7 @@ def marshal_dump
       end
 
       # Wraps block execution in a thread-safe transaction
-      def transaction(&block)
+      def transaction(&)
         guard.synchronize do
           yield
         end
@@ -90,7 +90,7 @@ def transaction(&block)
       #   store.each_rate do |iso_from, iso_to, rate|
       #     puts [iso_from, iso_to, rate].join
       #   end
-      def each_rate(&block)
+      def each_rate(&)
         return to_enum(:each_rate) unless block_given?
 
         guard.synchronize do