Improve specs and add code coverage

tagliala · tagliala · commit ae6207824d0d · 2025-07-10T16:35:26.000+02:00
- Add simplecov for code coverage. Run suite with `COVERAGE=1` - Use the modern configuration settings for `spec_helper.rb` There are failures with the default option `config.shared_context_metadata_behavior = :apply_to_host_groups`. This issue will be fixed separately, ref: #1136
diff --git a/.gitignore b/.gitignore
@@ -23,3 +23,4 @@ doc/
 /coverage
 .gem_rbs_collection
 .idea
+spec/examples.txt
diff --git a/.rspec b/.rspec
@@ -1,2 +1 @@
 --require spec_helper
---color
diff --git a/Gemfile b/Gemfile
@@ -7,4 +7,6 @@ gem 'pry', require: false
 gem 'rbs', platforms: %i[mri mingw x64_mingw]
 gem 'typeprof', platforms: %i[mri mingw x64_mingw]
 
+gem 'simplecov', require: false
+
 gemspec
diff --git a/spec/bank/base_spec.rb b/spec/bank/base_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe Money::Bank::Base do
+RSpec.describe Money::Bank::Base do
 
   describe ".instance" do
     it "is local to one class" do
diff --git a/spec/bank/single_currency_spec.rb b/spec/bank/single_currency_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe Money::Bank::SingleCurrency do
+RSpec.describe Money::Bank::SingleCurrency do
   describe "#exchange_with" do
     it "raises when called" do
       expect {
diff --git a/spec/bank/variable_exchange_spec.rb b/spec/bank/variable_exchange_spec.rb
@@ -3,7 +3,7 @@
 require 'json'
 require 'yaml'
 
-describe Money::Bank::VariableExchange do
+RSpec.describe Money::Bank::VariableExchange do
 
   describe "#initialize" do
     context "without &block" do
diff --git a/spec/currency/heuristics_spec.rb b/spec/currency/heuristics_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe Money::Currency::Heuristics do
+RSpec.describe Money::Currency::Heuristics do
   describe "#analyze_string" do
     it "it raises deprecation error" do
       expect { Money::Currency.analyze('123') }.to raise_error(StandardError, 'Heuristics deprecated, add `gem "money-heuristics"` to Gemfile')
diff --git a/spec/currency/loader_spec.rb b/spec/currency/loader_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe Money::Currency::Loader do
+RSpec.describe Money::Currency::Loader do
   it "returns a currency table hash" do
     expect(subject.load_currencies).to be_a Hash
   end
diff --git a/spec/currency_spec.rb b/spec/currency_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe Money::Currency do
+RSpec.describe Money::Currency do
   FOO = '{ "priority": 1, "iso_code": "FOO", "iso_numeric": "840", "name": "United States Dollar", "symbol": "$", "subunit": "Cent", "subunit_to_unit": 1000, "symbol_first": true, "html_entity": "$", "decimal_mark": ".", "thousands_separator": ",", "smallest_denomination": 1 }'
 
   def register_foo(opts={})
diff --git a/spec/locale_backend/currency_spec.rb b/spec/locale_backend/currency_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe Money::LocaleBackend::Currency do
+RSpec.describe Money::LocaleBackend::Currency do
   describe '#lookup' do
     let(:currency) { Money::Currency.new('EUR') }
 
diff --git a/spec/locale_backend/i18n_spec.rb b/spec/locale_backend/i18n_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe Money::LocaleBackend::I18n do
+RSpec.describe Money::LocaleBackend::I18n do
   describe '#initialize' do
     it 'raises an error when I18n is not defined' do
       hide_const('I18n')
diff --git a/spec/locale_backend/legacy_spec.rb b/spec/locale_backend/legacy_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe Money::LocaleBackend::Legacy do
+RSpec.describe Money::LocaleBackend::Legacy do
   after { Money.use_i18n = true }
 
   describe '#initialize' do
diff --git a/spec/money/allocation_spec.rb b/spec/money/allocation_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe Money::Allocation do
+RSpec.describe Money::Allocation do
    describe 'given number as argument' do
      it 'raises an error when invalid argument is given' do
       expect { described_class.generate(100, 0) }.to raise_error(ArgumentError)
diff --git a/spec/money/arithmetic_spec.rb b/spec/money/arithmetic_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe Money::Arithmetic do
+RSpec.describe Money::Arithmetic do
   describe "-@" do
     it "changes the sign of a number" do
       expect((- Money.new(0))).to  eq Money.new(0)
diff --git a/spec/money/constructors_spec.rb b/spec/money/constructors_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe Money::Constructors do
+RSpec.describe Money::Constructors do
 
   describe "::empty" do
     it "creates a new Money object of 0 cents" do
diff --git a/spec/money/formatting_rules_spec.rb b/spec/money/formatting_rules_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe Money::FormattingRules do
+RSpec.describe Money::FormattingRules do
   it 'does not modify frozen rules in place' do
     expect {
       Money::FormattingRules.new(Money::Currency.new('USD'), { separator: '.' }.freeze)
diff --git a/spec/money/formatting_spec.rb b/spec/money/formatting_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe Money, "formatting" do
+RSpec.describe Money, "formatting" do
 
   BAR = '{ "priority": 1, "iso_code": "BAR", "iso_numeric": "840", "name": "Dollar with 4 decimal places", "symbol": "$", "subunit": "Cent", "subunit_to_unit": 10000, "symbol_first": true, "html_entity": "$", "decimal_mark": ".", "thousands_separator": ",", "smallest_denomination": 1 }'
   INDIAN_BAR = '{ "priority": 1, "iso_code": "INDIAN_BAR", "iso_numeric": "840", "name": "Dollar with 4 decimal places", "symbol": "$", "subunit": "Cent", "subunit_to_unit": 10000, "symbol_first": true, "html_entity": "$", "decimal_mark": ".", "thousands_separator": ",", "south_asian_number_formatting": true, "smallest_denomination": 1}'
diff --git a/spec/money/locale_backend_spec.rb b/spec/money/locale_backend_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe Money::LocaleBackend do
+RSpec.describe Money::LocaleBackend do
   describe '.find' do
     it 'returns an initialized backend' do
       expect(described_class.find(:legacy)).to be_a(Money::LocaleBackend::Legacy)
diff --git a/spec/money_spec.rb b/spec/money_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe Money do
+RSpec.describe Money do
   describe '.locale_backend' do
     after { Money.locale_backend = :legacy }
 
diff --git a/spec/rates_store/memory_spec.rb b/spec/rates_store/memory_spec.rb
@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-describe Money::RatesStore::Memory do
+RSpec.describe Money::RatesStore::Memory do
   let(:subject) { described_class.new }
 
   describe '#add_rate and #get_rate' do
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -1,5 +1,15 @@
 # frozen_string_literal: true
 
+if ENV['COVERAGE']
+  require 'simplecov'
+
+  SimpleCov.start do
+    add_filter '/spec/'
+
+    track_files 'lib/**/*.rb'
+  end
+end
+
 $LOAD_PATH.unshift File.dirname(__FILE__)
 require "rspec"
 require "money"
@@ -8,10 +18,100 @@
 
 I18n.enforce_available_locales = false
 
-RSpec.configure do |c|
-  c.order = :random
-  c.filter_run :focus
-  c.run_all_when_everything_filtered = true
+# This file was generated by the `rspec --init` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# The generated `.rspec` file contains `--require spec_helper` which will cause
+# this file to always be loaded, without a need to explicitly require it in any
+# files.
+#
+# Given that it is always loaded, you are encouraged to keep this file as
+# light-weight as possible. Requiring heavyweight dependencies from this file
+# will add to the boot time of your test suite on EVERY test run, even for an
+# individual file that may not need all of that loaded. Instead, consider making
+# a separate helper file that requires the additional dependencies and performs
+# the additional setup, and require it from the spec files that actually need
+# it.
+#
+# See https://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+RSpec.configure do |config|
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    #     be_bigger_than(2).and_smaller_than(4).description
+    #     # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #     # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
+
+  # This option will default to `:apply_to_host_groups` in RSpec 4 (and will
+  # have no way to turn it off -- the option exists only for backwards
+  # compatibility in RSpec 3). It causes shared context metadata to be
+  # inherited by the metadata hash of host groups and examples, rather than
+  # triggering implicit auto-inclusion in groups with matching metadata.
+  # TODO: enable this option. Tracked in RubyMoney/money#1136
+  # config.shared_context_metadata_behavior = :apply_to_host_groups
+
+  # This allows you to limit a spec run to individual examples or groups
+  # you care about by tagging them with `:focus` metadata. When nothing
+  # is tagged with `:focus`, all examples get run. RSpec also provides
+  # aliases for `it`, `describe`, and `context` that include `:focus`
+  # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
+  config.filter_run_when_matching :focus
+
+  # Allows RSpec to persist some state between runs in order to support
+  # the `--only-failures` and `--next-failure` CLI options. We recommend
+  # you configure your source control system to ignore this file.
+  config.example_status_persistence_file_path = 'spec/examples.txt'
+
+  # Limits the available syntax to the non-monkey patched syntax that is
+  # recommended. For more details, see:
+  # https://rspec.info/features/3-12/rspec-core/configuration/zero-monkey-patching-mode/
+  config.disable_monkey_patching!
+
+  # This setting enables warnings. It's recommended, but in some cases may
+  # be too noisy due to issues in dependencies.
+  config.warnings = true
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = 'doc'
+  end
+
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  config.profile_examples = 10
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = :random
+
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
 end
 
 def reset_i18n
