Lint: Fix Style cops (#1203)

Author: sunny

.rubocop_todo.yml

@@ -78,8 +78,7 @@ def initialize(&block)
       #  +Money::Bank+ class.
       #
       # @return [self]
-      def setup
-      end
+      def setup; end
 
       # Exchanges the given +Money+ object to a new +Money+ object in
       # +to_currency+.

lib/money/bank/base.rb

@@ -45,7 +45,7 @@ def self.generate(amount, parts, decimal_cutoff = true)
 
       parts_sum = parts.sum
 
-      until parts.empty? do
+      until parts.empty?
         part = parts.pop
 
         current_split = 0

lib/money/money/allocation.rb

@@ -340,7 +340,7 @@ def zero?
     #   Money.new(100).nonzero? #=> #<Money @fractional=100>
     #   Money.new(0).nonzero?   #=> nil
     def nonzero?
-      fractional != 0 ? self : nil
+      fractional == 0 ? nil : self
     end
 
     # Used to make Money instance handle the operations when arguments order is reversed

lib/money/money/arithmetic.rb

@@ -34,7 +34,7 @@ def has_key?(key)
     #
     # @return [Hash]
     def normalize_formatting_rules(rules)
-      if rules.size == 0
+      if rules.empty?
         rules = {}
       elsif rules.size == 1
         rules = rules.pop

lib/money/money/formatting_rules.rb

@@ -243,6 +243,7 @@ def to_s
     end
   end
 
+  # rubocop:disable Style/MapIntoArray
   describe ".each" do
     it "yields each currency to the block" do
       expect(described_class).to respond_to(:each)
@@ -257,6 +258,7 @@ def to_s
       expect(currencies[-1]).to eq described_class.all[-1]
     end
   end
+  # rubocop:enable Style/MapIntoArray
 
   it "implements Enumerable" do
     expect(described_class).to respond_to(:all?)
@@ -483,13 +485,13 @@ def to_s
       cad = described_class.find(:cad)
 
       described_class.register(
-        :priority => 100,
-        :iso_code => cad.iso_code,
-        :name => cad.name,
-        :subunit => cad.subunit,
-        :subunit_to_unit => cad.subunit_to_unit,
-        :thousands_separator => cad.thousands_separator,
-        :decimal_mark => modified_mark,
+        priority: 100,
+        iso_code: cad.iso_code,
+        name: cad.name,
+        subunit: cad.subunit,
+        subunit_to_unit: cad.subunit_to_unit,
+        thousands_separator: cad.thousands_separator,
+        decimal_mark: modified_mark,
       )
     end
 

spec/currency_spec.rb

@@ -853,7 +853,7 @@
     end
   end
 
-  %w(+ - / divmod remainder).each do |op|
+  %w[+ - / divmod remainder].each do |op|
     describe "##{op}" do
       let(:instance) { Money.usd(1) }
 

spec/money/arithmetic_spec.rb

@@ -931,7 +931,7 @@
 
     it "keeps subclasses intact" do
       special_money_class = Class.new(Money)
-      expect(special_money_class.new(005).allocate([1]).first).to be_a special_money_class
+      expect(special_money_class.new(5).allocate([1]).first).to be_a special_money_class
     end
 
     context "with infinite_precision", :default_infinite_precision_true do