-
Notifications
You must be signed in to change notification settings - Fork 636
Open
Description
Hello,
Would you be interested in adding RuboCop to this project?
Do you have a preferred configuration file or any specific RuboCop settings you like to use?
I’ve introduced RuboCop to several gems I use, and my usual process is to open a series of pull requests:
- Stage I: Address all offenses in non-production code that are straightforward and unlikely to be controversial.
- Stage II: Tackle safe whitespace offenses in production code, focusing on changes where the "hide whitespace" diff remains minimal.
- Stage III: fix additional safe offenses in production code that are not likely to spark debate.
- Stage IV: Address unsafe offenses in production code that are also relatively uncontroversial.
- Other stages: Manual fixes
I would include the following extensions for this project:
- rubocop-packaging
- rubocop-performance
- rubocop-rspec
If this sounds good, I’d be happy to take care of the setup and submit incremental PRs for review
Here you can find an example: https://github.com/caxlsx/caxlsx/pulls?page=2&q=is%3Apr+rubocop+is%3Aclosed+author%3Atagliala+is%3Amerged
Please notice that introducing RuboCop can also help in improving performance, there is a couple of examples that I remember:
Sija and izkreny
Metadata
Metadata
Assignees
Labels
No labels