"bundled" in v0.34.3 is broken on Windows

[Eric-Arz]

Compilation of the crate fails with the following error:

failed to run custom build command for sdl2-sys v0.34.3

Explicity requesting v0.3.42 for sdl2-sys fixes the issue:

[dependencies.sdl2-sys]
version = "=0.34.2"

Everything then compiles & runs as it should.

[Cobrand]

If you can add details on what version of rust you use, what compiler (msvc or gnu) and more importantly what the complete error message is, I'm sure it will be helpful.

[Eric-Arz]

If you can add details on what version of rust you use, what compiler (msvc or gnu) and more importantly what the complete error message is, I'm sure it will be helpful.

I am using:

stable-x86_64-pc-windows-msvc (default)
rustc 1.43.0 (4fb7144ed 2020-04-20)

Full error message:

error: failed to run custom build command for `sdl2-sys v0.34.3`                                                          

Caused by:
  process didn't exit successfully: `C:\Users\username\Desktop\VSCode-Rust\target\debug\build\sdl2-sys-5c0ed5eddf780972\build-script-build` (exit code: 101)
--- stderr
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_ASM_FLAGS
    CMAKE_ASM_FLAGS_RELEASE


thread 'main' panicked at '
command did not execute successfully, got: exit code: 1

[Cobrand]

We don't know which command is failing so that will need a bit more debugging.

I don't have windows so either you'll have to wait until someone fixes that for you, or you'll have to fix that yourself I'm afraid.

I think you should try running the CMake file directly without the build.rs file, maybe that will give you a clue.

[aclysma]

I looked at it a little the other night and it fails here:

        for modified_file in patch_set.modified_files() {
            use std::io::{Write, BufRead};

            let file_path = sdl2_source_path.join(modified_file.path());
            let old_path = sdl2_source_path.join(format!("{}_old", modified_file.path()));
>>          fs::rename(&file_path, &old_path)
                .expect(&format!(
                    "Rename of {} to {} failed",
                    file_path.to_string_lossy(),
                    old_path.to_string_lossy()));

The filename, directory name, or volume label syntax is incorrect. (os error 123) on the fs::rename call

format!("{}_old" might should be old_{} but that doesn't fix it. The odd thing is, I made a throw-away program that called fs::rename on the same paths and it worked fine. Really seems like it would be easy to fix but I didn't figure out a working solution in the short amount of time I messed with it.

[ElhamAryanpur]

no fixes yet, still doesn't work on latest windows. mine is latest rust, I also have gcc 9.2 installed.

[aclysma]

For anyone looking for a quick workaround, you can use 0.34.2 by running this command:
cargo update --package sdl2-sys --precise 0.34.2

EDIT: sdl2-sys, not sdl2

[therocode]

The error I'm getting is that it seems like vcpkg is complaining about a casing difference between release and Release.

Vcpkg is unable to link because we cannot decide between Release and Debug libraries. Please define the property VcpkgConfiguration to be 'Release' or 'Debug' (currently 'release').

I assume from here -> https://github.com/Rust-SDL2/rust-sdl2/blob/master/sdl2-sys/build.rs#L273

?

[uhuntu]

I was switching to 0.34.3 at neovide on Windows, it was working very well, but I was using msvc.