`Surface::from_data` takes a mutable reference to the image data

[jonas-schievink]

It uses SDL_CreateRGBSurfaceFrom internally, whose first parameter is void*, but I see no reason (nor documentation) why it should change the data. It's probably a good idea to make it take a &[u8] instead of a &mut [u8], as that matches the expectation much better. If not, it should at least be documented why it needs mutable access.

[Cobrand]

There is no reason beside "sdl2 was made like this". Feel free to open a PR about that, I usually change these myself when I stumble on something that doesn't make sense, but I must have missed this one.

[Cobrand]

A little bit late to the party, but I actually think this is the intended behaviour.

::from_data creates a Surface which cannot live longer than the data given. However as far as I know you can still change the inside of the surface, and thus change the data as well, making it effectively mutable in this case.