[Windows] bundle + static-link - shell32 not linking, possible relation to rust pull #56568 (1.33+)

[0x08088405]

The following linker errors occur when trying to build with the bundled + static-link features on Windows:

libsdl2_sys-(snip).rlib(SDL_windowsevents.obj) : error LNK2019: unresolved external symbol __imp_DragQueryFileW referenced in function WIN_WindowProc

libsdl2_sys-(snip).rlib(SDL_windowsevents.obj) : error LNK2019: unresolved external symbol __imp_DragFinish referenced in function WIN_WindowProc

libsdl2_sys-(snip).rlib(SDL_windowsevents.obj) : error LNK2019: unresolved external symbol __imp_ExtractIconExW referenced in function SDL_RegisterApp_REAL

libsdl2_sys-(snip).rlib(SDL_sysfilesystem.obj) : error LNK2019: unresolved external symbol __imp_SHGetFolderPathW referenced in function SDL_GetPrefPath_REAL

libsdl2_sys-(snip).rlib(SDL_windowswindow.obj) : error LNK2019: unresolved external symbol __imp_DragAcceptFiles referenced in function WIN_AcceptDragAndDrop

All of these symbols appear to be from shell32, and I have downgraded to see if it builds on a version that is before pull #56568 (1.32) and sure enough it does. However right here in the build script it instructs it to link shell32, so this is quite puzzling.

No errors occur when building with only the bundled feature which copies the dynamic library.

[0x08088405]

Update... despite that line being there in the sdl2-sys build script, putting this as my build.rs makes it build fine, which would lead me to believe shell32 is in fact the culprit here. Removing it immediately emits the same linker errors again. I have no clue what's going on here.

fn main() {
    println!("cargo:rustc-link-lib=shell32");
}

[Cobrand]

Very interesting to say the least! If you indeed use the "static-link", shell32 should be linked as well thanks to the build.rs ...

[dmitsuki]

What is obvious is that

println!("cargo:rustc-link-lib=shell32");

is not being inserted into the build script if you check the output in your target folder. What isn't obvious is the cause. I forked the repo, was getting ready to try to fix it, checked if the output was being truncated but printing something else above it, saved the file and....it worked. Then I removed what I added...and it worked. My only guess at this point is some line ending thing might be effecting the output? I mean, it works on my machine, but I don't have any changes to put up for pull request. I just forked the repo, and then it just worked after basically saving the file locally.

[Lokathor]

For what it's worth, I'm getting the same error when I tried out static linking