Workspace-level lint configuration (#261)

Enables and fixes the same workspace-level lint configuration we
originally implemented in RustCrypto/utils#1411, but for this repo.

This primarily includes `clippy` lints, which have replaced the ones
configured in individual lib.rs files.

Since every crate in this repo previously declared `forbid(unsafe_code)`
this has also been moved to the workspace-level.

Author: tarcieri

.clippy.toml

@@ -0,0 +1,2 @@
+allow-unwrap-in-consts = true
+allow-unwrap-in-tests = true

Cargo.toml

@@ -11,3 +11,44 @@ members = [
 
 [profile.dev]
 opt-level = 2
+
+[workspace.lints.clippy]
+borrow_as_ptr = "warn"
+cast_lossless = "warn"
+cast_possible_truncation = "warn"
+cast_possible_wrap = "warn"
+cast_precision_loss = "warn"
+cast_sign_loss = "warn"
+checked_conversions = "warn"
+doc_markdown = "warn"
+from_iter_instead_of_collect = "warn"
+implicit_saturating_sub = "warn"
+manual_assert = "warn"
+map_unwrap_or = "warn"
+missing_errors_doc = "warn"
+missing_panics_doc = "warn"
+mod_module_files = "warn"
+must_use_candidate = "warn"
+needless_range_loop = "allow"
+ptr_as_ptr = "warn"
+redundant_closure_for_method_calls = "warn"
+ref_as_ptr = "warn"
+return_self_not_must_use = "warn"
+semicolon_if_nothing_returned = "warn"
+trivially_copy_pass_by_ref = "warn"
+std_instead_of_alloc = "warn"
+std_instead_of_core = "warn"
+undocumented_unsafe_blocks = "warn"
+unnecessary_safety_comment = "warn"
+unwrap_in_result = "warn"
+unwrap_used = "warn"
+
+[workspace.lints.rust]
+missing_copy_implementations = "warn"
+missing_debug_implementations = "warn"
+missing_docs = "warn"
+trivial_casts = "warn"
+trivial_numeric_casts = "warn"
+unsafe_code = "forbid"
+unused_lifetimes = "warn"
+unused_qualifications = "warn"

belt-mac/Cargo.toml

@@ -24,5 +24,8 @@ hex-literal = "1"
 [features]
 zeroize = ["cipher/zeroize", "digest/zeroize"]
 
+[lints]
+workspace = true
+
 [package.metadata.docs.rs]
 all-features = true

belt-mac/README.md

@@ -1,4 +1,4 @@
-# RustCrypto: belt-mac
+# [RustCrypto]: belt-mac
 
 [![crate][crate-image]][crate-link]
 [![Docs][docs-image]][docs-link]
@@ -61,4 +61,5 @@ dual licensed as above, without any additional terms or conditions.
 
 [//]: # (general links)
 
+[RustCrypto]: https://github.com/RustCrypto
 [1]: https://apmi.bsu.by/assets/files/std/belt-spec371.pdf

belt-mac/src/block_api.rs

@@ -14,7 +14,7 @@ use digest::{
 #[cfg(feature = "zeroize")]
 use digest::zeroize::{Zeroize, ZeroizeOnDrop};
 
-/// Generic core BeltMac instance, which operates over blocks.
+/// Generic core Belt MAC instance, which operates over blocks.
 #[derive(Clone)]
 pub struct BeltMacCore<C>
 where
@@ -94,7 +94,7 @@ where
         }
 
         let Self { cipher, state, .. } = self;
-        cipher.encrypt_with_backend(Closure { state, blocks })
+        cipher.encrypt_with_backend(Closure { state, blocks });
     }
 }
 

belt-mac/src/lib.rs

@@ -5,8 +5,6 @@
     html_favicon_url = "https://raw.githubusercontent.com/RustCrypto/media/26acc39f/logo.svg"
 )]
 #![cfg_attr(docsrs, feature(doc_cfg))]
-#![forbid(unsafe_code)]
-#![warn(missing_docs)]
 
 pub use digest::{self, KeyInit, Mac};
 
@@ -17,11 +15,11 @@ use cipher::BlockCipherEncrypt;
 use digest::block_api::SmallBlockSizeUser;
 
 digest::buffer_fixed!(
-    /// BeltMac instance generic over block cipher.
+    /// Belt MAC instance generic over block cipher.
     #[derive(Clone)]
     pub struct GenericBeltMac<C: BlockCipherEncrypt + SmallBlockSizeUser>(block_api::BeltMacCore<C>);
     impl: ResetMacTraits AlgorithmName InnerInit;
 );
 
-/// BeltMac instance.
+/// Belt MAC instance.
 pub type BeltMac = GenericBeltMac<belt_block::BeltBlock>;

belt-mac/tests/mod.rs

@@ -1,3 +1,5 @@
+//! Test vectors.
+
 //use belt_mac::BeltMac;
 
 // TODO(tarcieri): update tests to support RustCrypto/traits#1916

cbc-mac/Cargo.toml

@@ -25,5 +25,8 @@ des = "0.9.0-rc.3"
 [features]
 zeroize = ["cipher/zeroize", "digest/zeroize"]
 
+[lints]
+workspace = true
+
 [package.metadata.docs.rs]
 all-features = true

cbc-mac/README.md

@@ -1,4 +1,4 @@
-# RustCrypto: CBC-MAC
+# [RustCrypto]: CBC-MAC
 
 [![crate][crate-image]][crate-link]
 [![Docs][docs-image]][docs-link]
@@ -60,4 +60,5 @@ dual licensed as above, without any additional terms or conditions.
 
 [//]: # (general links)
 
+[RustCrypto]: https://github.com/RustCrypto
 [CBC-MAC]: https://en.wikipedia.org/wiki/CBC-MAC

cbc-mac/src/block_api.rs

@@ -91,7 +91,7 @@ where
         }
 
         let Self { cipher, state } = self;
-        cipher.encrypt_with_backend(Closure { state, blocks })
+        cipher.encrypt_with_backend(Closure { state, blocks });
     }
 }