Workspace-level lint configuration

Enables and fixes the same workspace-level lint configuration we
originally implemented in RustCrypto/utils#1411, but for this repo.

This primarily includes `clippy` lints, which have replaced the ones
configured in individual lib.rs files.

Since every crate in this repo previously declared `forbid(unsafe_code)`
this has also been moved to the workspace-level.

Author: tarcieri

.clippy.toml

@@ -0,0 +1,2 @@
+allow-unwrap-in-consts = true
+allow-unwrap-in-tests = true

Cargo.toml

@@ -14,3 +14,44 @@ members = [
 
 [profile.dev]
 opt-level = 2
+
+[workspace.lints.clippy]
+borrow_as_ptr = "warn"
+cast_lossless = "warn"
+cast_possible_truncation = "warn"
+cast_possible_wrap = "warn"
+cast_precision_loss = "warn"
+cast_sign_loss = "warn"
+checked_conversions = "warn"
+# doc_markdown = "warn"
+from_iter_instead_of_collect = "warn"
+implicit_saturating_sub = "warn"
+manual_assert = "warn"
+map_unwrap_or = "warn"
+missing_errors_doc = "warn"
+missing_panics_doc = "warn"
+mod_module_files = "warn"
+must_use_candidate = "warn"
+needless_range_loop = "allow"
+ptr_as_ptr = "warn"
+redundant_closure_for_method_calls = "warn"
+ref_as_ptr = "warn"
+return_self_not_must_use = "warn"
+semicolon_if_nothing_returned = "warn"
+trivially_copy_pass_by_ref = "warn"
+std_instead_of_alloc = "warn"
+std_instead_of_core = "warn"
+undocumented_unsafe_blocks = "warn"
+unnecessary_safety_comment = "warn"
+unwrap_in_result = "warn"
+unwrap_used = "warn"
+
+[workspace.lints.rust]
+missing_copy_implementations = "warn"
+missing_debug_implementations = "warn"
+missing_docs = "warn"
+trivial_casts = "warn"
+trivial_numeric_casts = "warn"
+unsafe_code = "forbid"
+unused_lifetimes = "warn"
+unused_qualifications = "warn"

belt-ctr/Cargo.toml

@@ -25,6 +25,8 @@ cipher = { version = "0.5", features = ["dev"] }
 alloc = ["cipher/alloc"]
 zeroize = ["cipher/zeroize"]
 
+[lints]
+workspace = true
+
 [package.metadata.docs.rs]
 all-features = true
-rustdoc-args = ["--cfg", "docsrs"]

belt-ctr/src/lib.rs

@@ -4,9 +4,7 @@
     html_logo_url = "https://raw.githubusercontent.com/RustCrypto/media/6ee8e381/logo.svg",
     html_favicon_url = "https://raw.githubusercontent.com/RustCrypto/media/6ee8e381/logo.svg"
 )]
-#![forbid(unsafe_code)]
 #![cfg_attr(docsrs, feature(doc_cfg))]
-#![warn(missing_debug_implementations, missing_docs, rust_2018_idioms)]
 
 pub use cipher;
 
@@ -58,7 +56,7 @@ where
             #[inline(always)]
             fn call<B: BlockCipherEncBackend<BlockSize = U16>>(self, cipher_backend: &B) {
                 let Self { s, f } = self;
-                f.call(&mut Backend { s, cipher_backend })
+                f.call(&mut Backend { s, cipher_backend });
             }
         }
 

cbc/Cargo.toml

@@ -26,6 +26,8 @@ alloc = ["cipher/alloc"]
 block-padding = ["cipher/block-padding"]
 zeroize = ["cipher/zeroize"]
 
+[lints]
+workspace = true
+
 [package.metadata.docs.rs]
 all-features = true
-rustdoc-args = ["--cfg", "docsrs"]

cbc/src/decrypt.rs

@@ -66,7 +66,7 @@ where
         }
 
         let Self { cipher, iv } = self;
-        cipher.decrypt_with_backend(Closure { iv, f })
+        cipher.decrypt_with_backend(Closure { iv, f });
     }
 }
 
@@ -188,7 +188,7 @@ where
         let n = t.len();
         xor(&mut t[0], self.iv);
         for i in 1..n {
-            xor(&mut t[i], &in_blocks[i - 1])
+            xor(&mut t[i], &in_blocks[i - 1]);
         }
         *blocks.get_out() = t;
         *self.iv = in_blocks[n - 1].clone();

cbc/src/encrypt.rs

@@ -100,7 +100,7 @@ where
         }
 
         let Self { cipher, iv } = self;
-        cipher.encrypt_with_backend(Closure { iv, f })
+        cipher.encrypt_with_backend(Closure { iv, f });
     }
 }
 

cbc/src/lib.rs

@@ -95,9 +95,7 @@
     html_logo_url = "https://raw.githubusercontent.com/RustCrypto/media/6ee8e381/logo.svg",
     html_favicon_url = "https://raw.githubusercontent.com/RustCrypto/media/6ee8e381/logo.svg"
 )]
-#![forbid(unsafe_code)]
 #![cfg_attr(docsrs, feature(doc_cfg))]
-#![warn(missing_debug_implementations, missing_docs, rust_2018_idioms)]
 
 mod decrypt;
 mod encrypt;

cbc/tests/iv_state.rs

@@ -1,3 +1,5 @@
+//! IV state tests.
+
 use aes::*;
 use cbc::{Decryptor, Encryptor};
 use cipher::iv_state_test;

cfb-mode/Cargo.toml

@@ -26,6 +26,8 @@ alloc = ["cipher/alloc"]
 block-padding = ["cipher/block-padding"]
 zeroize = ["cipher/zeroize"]
 
+[lints]
+workspace = true
+
 [package.metadata.docs.rs]
 all-features = true
-rustdoc-args = ["--cfg", "docsrs"]