`bignp256` release

[makavity]

Hey, @tarcieri
Is there anything I should do before release bignp256 0.14.0?
If nothing (instead of bign-genk release), could we release it?
Thank you!

[tarcieri]

@makavity I've been meaning to try to bring it closer to the other curve implementations including removing redundant types that duplicate the elliptic-curve crate like PublicKey and SecretKey.

If you'd like to do that instead, that'd be great.

[makavity]

Yeah, I’ll try it. Thanks for feedback

[makavity]

@tarcieri
I’ve inspected the elliptic-curve types: PublicKey and SecretKey and noticed that only sec1 is possible encoding and decoding format, but in STB there is only raw encoding, without 0x04 tag, that I’m trimming in bundled version.
Is there any way to do the raw encoding in the terms of elliptic-curve crate that I’m missing?

[tarcieri]

The closest thing is probably Sec1Point::from_untagged_bytes.

PublicKey and SecretKey shouldn't receive implementations of the sec1 traits except if your point types actually impl FromSec1Point/ToSec1Point, but I'm guessing you're inheriting those impls by way of primeorder.

At the very least, you shouldn't duplicate all of the functionality of PublicKey/SecretKey in a copy/paste manner, but write newtypes for the types from elliptic-curve.

You could potentially make wrapper newtypes for AffinePoint/ProjectivePoint which would opt you out of the sec1 trait impls which are currently mandatory in primeorder. You would probably need a set of replacement traits for FromSec1Point/ToSec1Point. In a future version of primeorder we can probably add something to PrimeCurveParams to give curves more control of the encoding.

[makavity]

Hey, @tarcieri !
Is there anything else in your opinion what should be changed/fixed before release?

[tarcieri]

Sorry, I'm a million years behind on anything @RustCrypto, we just had a 40C day my heat pump broke and I'm waiting for it to be repaired

[makavity]

Sorry, I'm a million years behind on anything @RustCrypto, we just had a 40C day my heat pump broke and I'm waiting for it to be repaired

Sounds terrible. No problem, I'll wait. Don't burn out :D