poly1305: add lint configs to Cargo.toml

Uses most of the standard lints we've applied elsewhere, with a couple
of TODOs

Author: tarcieri

poly1305/Cargo.toml

@@ -22,9 +22,49 @@ cpufeatures = "0.3"
 [dev-dependencies]
 hex-literal = "1"
 
+[lints.rust]
+missing_copy_implementations = "warn"
+missing_debug_implementations = "warn"
+missing_docs = "warn"
+trivial_casts = "warn"
+trivial_numeric_casts = "warn"
+unused_lifetimes = "warn"
+unused_qualifications = "warn"
+unreachable_pub = "warn"
+
 [lints.rust.unexpected_cfgs]
 level = "warn"
 check-cfg = [
     'cfg(fuzzing)',
     'cfg(poly1305_backend, values("soft"))'
 ]
+
+[lints.clippy]
+borrow_as_ptr = "warn"
+cast_lossless = "warn"
+cast_possible_truncation = "allow" # TODO(tarcieri): warn
+cast_possible_wrap = "warn"
+cast_precision_loss = "warn"
+cast_sign_loss = "warn"
+checked_conversions = "warn"
+from_iter_instead_of_collect = "warn"
+implicit_saturating_sub = "warn"
+manual_assert = "warn"
+map_unwrap_or = "warn"
+missing_errors_doc = "warn"
+missing_panics_doc = "warn"
+mod_module_files = "warn"
+must_use_candidate = "warn"
+needless_range_loop = "allow"
+ptr_as_ptr = "warn"
+redundant_closure_for_method_calls = "warn"
+ref_as_ptr = "warn"
+return_self_not_must_use = "warn"
+semicolon_if_nothing_returned = "warn"
+trivially_copy_pass_by_ref = "warn"
+std_instead_of_alloc = "warn"
+std_instead_of_core = "warn"
+undocumented_unsafe_blocks = "warn"
+unnecessary_safety_comment = "warn"
+unwrap_in_result = "warn"
+unwrap_used = "allow" # TODO(tarcieri): warn

poly1305/benches/poly1305.rs

@@ -1,3 +1,5 @@
+//! Poly1305 benchmarks.
+
 #![feature(test)]
 
 extern crate test;

poly1305/src/lib.rs

@@ -4,7 +4,6 @@
     html_logo_url = "https://raw.githubusercontent.com/RustCrypto/media/8f1a9894/logo.svg",
     html_favicon_url = "https://raw.githubusercontent.com/RustCrypto/media/8f1a9894/logo.svg"
 )]
-#![warn(missing_docs)]
 
 pub use universal_hash;
 
@@ -95,6 +94,7 @@ impl Poly1305 {
     /// Compute unpadded Poly1305 for the given input data.
     ///
     /// The main use case for this is XSalsa20Poly1305.
+    #[must_use]
     pub fn compute_unpadded(mut self, data: &[u8]) -> Tag {
         let (blocks, remaining) = Block::slice_as_chunks(data);
 

poly1305/tests/lib.rs

@@ -1,9 +1,11 @@
+//! Poly1305 integration tests.
+
+use core::iter::repeat_n;
 use hex_literal::hex;
 use poly1305::{
     Block, KEY_SIZE, Poly1305,
     universal_hash::{KeyInit, UniversalHash},
 };
-use std::iter::repeat_n;
 
 #[test]
 fn test_nacl_vector() {