inout: fix needless_lifetimes lint (#1167)

Author: newpavlov

inout/src/inout.rs

@@ -13,7 +13,7 @@ pub struct InOut<'inp, 'out, T> {
 impl<'inp, 'out, T> InOut<'inp, 'out, T> {
     /// Reborrow `self`.
     #[inline(always)]
-    pub fn reborrow<'a>(&'a mut self) -> InOut<'a, 'a, T> {
+    pub fn reborrow(&mut self) -> InOut<'_, '_, T> {
         Self {
             in_ptr: self.in_ptr,
             out_ptr: self.out_ptr,
@@ -23,13 +23,13 @@ impl<'inp, 'out, T> InOut<'inp, 'out, T> {
 
     /// Get immutable reference to the input value.
     #[inline(always)]
-    pub fn get_in<'a>(&'a self) -> &'a T {
+    pub fn get_in(&self) -> &T {
         unsafe { &*self.in_ptr }
     }
 
     /// Get mutable reference to the output value.
     #[inline(always)]
-    pub fn get_out<'a>(&'a mut self) -> &'a mut T {
+    pub fn get_out(&mut self) -> &mut T {
         unsafe { &mut *self.out_ptr }
     }
 
@@ -73,7 +73,7 @@ impl<'inp, 'out, T> InOut<'inp, 'out, T> {
     }
 }
 
-impl<'inp, 'out, T: Clone> InOut<'inp, 'out, T> {
+impl<T: Clone> InOut<'_, '_, T> {
     /// Clone input value and return it.
     #[inline(always)]
     pub fn clone_in(&self) -> T {
@@ -110,7 +110,7 @@ impl<'inp, 'out, T, N: ArraySize> InOut<'inp, 'out, Array<T, N>> {
     /// # Panics
     /// If `pos` greater or equal to array length.
     #[inline(always)]
-    pub fn get<'a>(&'a mut self, pos: usize) -> InOut<'a, 'a, T> {
+    pub fn get(&mut self, pos: usize) -> InOut<'_, '_, T> {
         assert!(pos < N::USIZE);
         unsafe {
             InOut {
@@ -133,7 +133,7 @@ impl<'inp, 'out, T, N: ArraySize> InOut<'inp, 'out, Array<T, N>> {
     }
 }
 
-impl<'inp, 'out, N: ArraySize> InOut<'inp, 'out, Array<u8, N>> {
+impl<N: ArraySize> InOut<'_, '_, Array<u8, N>> {
     /// XOR `data` with values behind the input slice and write
     /// result to the output slice.
     ///
@@ -153,7 +153,7 @@ impl<'inp, 'out, N: ArraySize> InOut<'inp, 'out, Array<u8, N>> {
     }
 }
 
-impl<'inp, 'out, N, M> InOut<'inp, 'out, Array<Array<u8, N>, M>>
+impl<N, M> InOut<'_, '_, Array<Array<u8, N>, M>>
 where
     N: ArraySize,
     M: ArraySize,

inout/src/inout_buf.rs

@@ -98,7 +98,7 @@ impl<'inp, 'out, T> InOutBuf<'inp, 'out, T> {
     /// # Panics
     /// If `pos` greater or equal to buffer length.
     #[inline(always)]
-    pub fn get<'a>(&'a mut self, pos: usize) -> InOut<'a, 'a, T> {
+    pub fn get(&mut self, pos: usize) -> InOut<'_, '_, T> {
         assert!(pos < self.len);
         unsafe {
             InOut {
@@ -111,13 +111,13 @@ impl<'inp, 'out, T> InOutBuf<'inp, 'out, T> {
 
     /// Get input slice.
     #[inline(always)]
-    pub fn get_in<'a>(&'a self) -> &'a [T] {
+    pub fn get_in(&self) -> &[T] {
         unsafe { slice::from_raw_parts(self.in_ptr, self.len) }
     }
 
     /// Get output slice.
     #[inline(always)]
-    pub fn get_out<'a>(&'a mut self) -> &'a mut [T] {
+    pub fn get_out(&mut self) -> &mut [T] {
         unsafe { slice::from_raw_parts_mut(self.out_ptr, self.len) }
     }
 
@@ -135,7 +135,7 @@ impl<'inp, 'out, T> InOutBuf<'inp, 'out, T> {
 
     /// Reborrow `self`.
     #[inline(always)]
-    pub fn reborrow<'a>(&'a mut self) -> InOutBuf<'a, 'a, T> {
+    pub fn reborrow(&mut self) -> InOutBuf<'_, '_, T> {
         Self {
             in_ptr: self.in_ptr,
             out_ptr: self.out_ptr,
@@ -233,7 +233,7 @@ impl<'inp, 'out, T> InOutBuf<'inp, 'out, T> {
     }
 }
 
-impl<'inp, 'out> InOutBuf<'inp, 'out, u8> {
+impl InOutBuf<'_, '_, u8> {
     /// XORs `data` with values behind the input slice and write
     /// result to the output slice.
     ///

inout/src/lib.rs

@@ -7,7 +7,6 @@
     html_favicon_url = "https://raw.githubusercontent.com/RustCrypto/media/8f1a9894/logo.svg"
 )]
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
-#![allow(clippy::needless_lifetimes)]
 #![warn(missing_docs)]
 
 #[cfg(feature = "block-padding")]

inout/src/reserved.rs

@@ -96,7 +96,7 @@ impl<T> InOutBufReserved<'_, '_, T> {
 
     /// Split buffer into `InOutBuf` with input length and mutable slice pointing to
     /// the reamining reserved suffix.
-    pub fn split_reserved<'a>(&'a mut self) -> (InOutBuf<'a, 'a, T>, &'a mut [T]) {
+    pub fn split_reserved(&mut self) -> (InOutBuf<'_, '_, T>, &mut [T]) {
         let in_len = self.get_in_len();
         let out_len = self.get_out_len();
         let in_ptr = self.get_in().as_ptr();
@@ -132,13 +132,13 @@ impl<'inp, 'out, T> InOutBufReserved<'inp, 'out, T> {
 
     /// Get input slice.
     #[inline(always)]
-    pub fn get_in<'a>(&'a self) -> &'a [T] {
+    pub fn get_in(&self) -> &[T] {
         unsafe { slice::from_raw_parts(self.in_ptr, self.in_len) }
     }
 
     /// Get output slice.
     #[inline(always)]
-    pub fn get_out<'a>(&'a mut self) -> &'a mut [T] {
+    pub fn get_out(&mut self) -> &mut [T] {
         unsafe { slice::from_raw_parts_mut(self.out_ptr, self.out_len) }
     }
 
@@ -212,10 +212,10 @@ pub struct PaddedInOutBuf<'inp, 'out, BS: ArraySize> {
 }
 
 #[cfg(feature = "block-padding")]
-impl<'inp, 'out, BS: ArraySize> PaddedInOutBuf<'inp, 'out, BS> {
+impl<'out, BS: ArraySize> PaddedInOutBuf<'_, 'out, BS> {
     /// Get full blocks.
     #[inline(always)]
-    pub fn get_blocks<'a>(&'a mut self) -> InOutBuf<'a, 'a, Array<u8, BS>> {
+    pub fn get_blocks(&mut self) -> InOutBuf<'_, '_, Array<u8, BS>> {
         self.blocks.reborrow()
     }
 
@@ -224,7 +224,7 @@ impl<'inp, 'out, BS: ArraySize> PaddedInOutBuf<'inp, 'out, BS> {
     /// For paddings with `P::TYPE = PadType::Reversible` it always returns `Some`.
     #[inline(always)]
     #[allow(clippy::needless_option_as_deref)]
-    pub fn get_tail_block<'a>(&'a mut self) -> Option<InOut<'a, 'a, Array<u8, BS>>> {
+    pub fn get_tail_block(&mut self) -> Option<InOut<'_, '_, Array<u8, BS>>> {
         match self.tail_out.as_deref_mut() {
             Some(out_block) => Some((&self.tail_in, out_block).into()),
             None => None,