Optimized connection creation for yahoo

Author: jczaja

src/divanalysis/main.rs

@@ -1,7 +1,7 @@
 use calamine::{open_workbook, Xlsx};
 use clap::Parser;
-use polars::prelude::*;
 use indicatif::ProgressBar;
+use polars::prelude::*;
 
 // TODO: Make progressbar
 // TODO: convert dividends derived elements into TTM data
@@ -235,8 +235,6 @@ fn get_companies_data(
     database: Option<String>,
     target_yield: f64,
 ) -> Result<(), &'static str> {
-
-
     // If we have explicitly given companies then make progress bar with specific length
     // otherwise just make the one without length
     let pb = if companies.is_empty() {
@@ -321,6 +319,10 @@ fn get_companies_data(
         df
     };
 
+    let use_polygon = std::env::var("POLYGON_AUTH_KEY").is_ok();
+    let mut provider = investments_forecasting::get_yahoo_connector()
+        .map_err(|_| "Error: Unable to create yahoo connector")?;
+
     let maybe_success = companies.iter().try_for_each(|symbol| {
         let (
             share_price,
@@ -335,11 +337,12 @@ fn get_companies_data(
             years_of_growth,
             payout_ratio,
             sector_desc,
-        ) = if std::env::var("POLYGON_AUTH_KEY").is_ok() {
+        ) = if use_polygon {
             investments_forecasting::get_polygon_data(symbol)
                 .expect("Error: unable to get Data from polygon IO for forecasting")
         } else {
-            investments_forecasting::get_yahoo_data(symbol)
+            let myref = provider.as_mut().unwrap();
+            investments_forecasting::get_yahoo_data(symbol, myref)
                 .expect("Error: unable to get Data from yahoo finance for forecasting")
         };
 
@@ -515,18 +518,13 @@ fn main() -> Result<(), &'static str> {
         None
     };
 
-
-
     //let company = <std::string::String as AsRef<str>>::as_ref(&args.company).to_uppercase();
     let companies = args
         .company
         .iter()
         .map(|x| x.to_uppercase())
         .collect::<Vec<String>>();
 
-
-
-
     // For no handpicked companies just make overall analysis
     if companies.len() == 0 {
         if args.list_all {

src/divforecasting/main.rs

@@ -342,7 +342,8 @@ fn forecast_dividend_stocks(
                         if std::env::var("POLYGON_AUTH_KEY").is_ok() { 
                             investments_forecasting::get_polygon_data(&name).expect("Error: unable to get Data from polygon IO for forecasting")
                         } else {
-                            investments_forecasting::get_yahoo_data(&name).expect("Error: unable to get Data from yahoo finance for forecasting")
+                            let provider = investments_forecasting::get_yahoo_connector().expect("Unable to create yahoo connector");
+                            investments_forecasting::get_yahoo_data(&name,&mut provider.unwrap()).expect("Error: unable to get Data from yahoo finance for forecasting")
                         };
                         num_capitalizations = frequency.expect("Cannot forecast dividend gains as there is no dividend data") as u32;
                         let divy = divy.expect("Cannot forecast dividend gains as there is no dividend data");

src/lib.rs

@@ -10,8 +10,15 @@ use polygon_client::rest::RESTClient;
 use std::collections::BTreeMap;
 use std::collections::HashMap;
 
-// TODO: connector reuse of yahoo
-
+pub fn get_yahoo_connector() -> Result<Option<yahoo::YahooConnector>, String> {
+    if std::env::var("POLYGON_AUTH_KEY").is_ok() {
+        Ok(None)
+    } else {
+        Ok(Some(yahoo::YahooConnector::new().map_err(|_| {
+            "Could not create Yahoo provider".to_owned()
+        })?))
+    }
+}
 
 pub fn load_list<R>(excel: &mut Xlsx<R>, category: &str) -> Result<DataFrame, &'static str>
 where
@@ -591,6 +598,7 @@ async fn get_dividiend_data(
 }
 pub fn get_yahoo_data(
     company: &str,
+    provider: &mut yahoo::YahooConnector,
 ) -> Result<
     (
         f64,
@@ -609,9 +617,6 @@ pub fn get_yahoo_data(
     &'static str,
 > {
     log::info!("Yahoo: Getting Ticker: {}", company);
-    // create provider
-    let mut provider =
-        yahoo::YahooConnector::new().map_err(|_| "Could not create Yahoo provider")?;
 
     // stock price
     let response = provider.get_latest_quotes(company, "1d").map_err(|e| {